fix(dependency_updater): prevent infinite pagination loop by checking NextPage before advancing #609
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The previous pagination logic placed the
resp.NextPage == 0check in an unreachableelse ifbranch competing with TagPrefix conditions. As a result, when TagPrefix != "" and no matching release is found on the last page, the code set options.Page = 0 and could loop indefinitely.This change:
resp.NextPage == 0termination check to run before assigningoptions.Page = resp.NextPage.else if resp.NextPage == 0branch.The new flow follows the official go-github pagination example pattern, ensuring the loop exits correctly and preventing infinite iteration.