-
Notifications
You must be signed in to change notification settings - Fork 235
Bal 3860 split review completed status into 3 resolution outcomes #3265
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
chesterkmr
merged 12 commits into
dev
from
bal-3860-split-review-completed-status-into-3-resolution-outcomes
Apr 29, 2025
Merged
Changes from 7 commits
Commits
Show all changes
12 commits
Select commit
Hold shift + click to select a range
edd0b36
feat: added merchant monitoring report statuses to common
chesterkmr 2a9aec1
feat: added new statuses to web presence table & updated dialog layout
chesterkmr 1e20db3
feat: restored completed merchant report status
chesterkmr 3dd05c8
feat: additional details now required
chesterkmr 0042d6d
Merge branch 'dev' into bal-3860-split-review-completed-status-into-3…
chesterkmr 45b1612
feat: finalized new report statuses
chesterkmr 560e6fb
chore: bump
chesterkmr 1d4c730
Merge branch 'dev' into bal-3860-split-review-completed-status-into-3…
chesterkmr 848719c
feat: updated microcopy & status mapping fixes
chesterkmr 682b30c
Merge branch 'dev' into bal-3860-split-review-completed-status-into-3…
chesterkmr 47c4a82
feat: added dom purify sanitization to notes
chesterkmr 9b27c94
Merge branch 'dev' into bal-3860-split-review-completed-status-into-3…
chesterkmr File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
10 changes: 10 additions & 0 deletions
10
...hantMonitoring/components/MerchantMonitoringReportStatus/helpers/get-base-note-content.ts
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,10 @@ | ||
import { toStartCase } from '@/common/utils/to-start-case/to-start-case'; | ||
|
||
export const getBaseNoteContent = (status: string, text: string) => ` | ||
<div class="flex flex-col"> | ||
<span class="text-xs leading-6 text-slate-500">Status changed to <span class="font-semibold">'${toStartCase( | ||
status, | ||
)}'</span> | ||
${text ? ` with details:</span><div class="text-sm">${text}</div>` : '</span>'} | ||
</div> | ||
`; | ||
coderabbitai[bot] marked this conversation as resolved.
Show resolved
Hide resolved
|
11 changes: 11 additions & 0 deletions
11
...ing/components/MerchantMonitoringReportStatus/helpers/get-note-content-for-unsubscribe.ts
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,11 @@ | ||
import { toStartCase } from '@/common/utils/to-start-case/to-start-case'; | ||
|
||
export const getNoteContentForUnsubscribe = (status: string, text: string) => ` | ||
<div class="flex flex-col"> | ||
<span class="text-xs leading-6 text-slate-500"> | ||
Status changed to <span class="font-semibold">"${toStartCase( | ||
status, | ||
)},"</span> and the merchant was <b>unsubscribed from ongoing monitoring</b> | ||
${text ? ` with details:</span><div class="text-sm">${text}</div>` : '</span>'} | ||
</div> | ||
`; |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.