-
Notifications
You must be signed in to change notification settings - Fork 55
Refactor the Ballerina Docs for the Alfresco Connector #849
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
| * Create an [Alfresco Account](https://www.alfresco.com/try-alfresco-acs). | ||
| * Once registered, you will receive an email with instructions to set up your Alfresco environment, including the default username and password. Use these Basic Authentication credentials to access the Alfresco Content Services API. | ||
|
|
||
| ## Quickstart |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Shall we follow the same structure as the revamped connectors for quick-start guide ?
https://github.com/ballerina-platform/module-ballerinax-stripe?tab=readme-ov-file#quickstart
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR refactors the Quickstart documentation for the Alfresco connector, updating authentication instructions, renaming configuration types, and adding execution steps.
- Clarifies Basic Authentication setup and removes bearer token step
- Updates code snippets to use
alfresco:ConnectionConfigwithusername/password - Adds a “Run” step with the
bal runcommand
Comments suppressed due to low confidence (2)
openapi/alfresco/Module.md:29
- [nitpick] Consider renaming the variable
clientConfigtoconnectionConfigto match its type and improve consistency.
alfresco:ConnectionConfig clientConfig = {
openapi/alfresco/Module.md:43
- The example uses
serviceURLbut does not define it; include aconfigurable string serviceURL = ?;declaration above so the snippet is self-contained.
alfresco:Client baseClient = check new (clientConfig, serviceURL);
Add suggestions from code review Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Nuvindu Nirmana <63797478+Nuvindu@users.noreply.github.com>
Description
Fixes: ballerina-platform/ballerina-library#7922
Related Pull Requests (remove if not relevant)
One line release note:
Type of change
Please delete options that are not relevant.
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration
Test Configuration:
Checklist:
Changes to OpenAPI definition
Modified
infosection of the OpenAPI definition file - Exampledescription- what the connector is aboutx-ballerina-init-descriptionOpenAPI extension - connector initialization detailsx-ballerina-displayOpenAPI extension - connector name and path to the connector iconAdded proper description each API Key, if API Key authentication is defined in OpenAPI definition file
Changes to connector module
pngof 200x200 px size with nameicon.pngVerifying connector module
Security checks