Various tweaks #17
Open
Various tweaks #17
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Apparently the GitHub Packages Docker Registry is being replaced by the Container registry, which among other advantages allows anonymous access to public images, which seems useful.
When the minimum retention interval supported is an hour, it seems a little silly to check for messages every minute. When the minimum retention interval configured is a month, it seems extra silly. 10% is probably a reasonable error margin in retention interval, and probably means significantly less time processing.
|
Hey, thanks so much for the PR! 🙌 Definitely going to check it out in the next days. |
bahlo
requested changes
Jun 20, 2021
| if: github.ref == 'refs/heads/container' | ||
| run: | | ||
| docker build -t ghcr.io/${GITHUB_REPOSITORY}/discord-retention-bot:testing . | ||
| docker push ghcr.io/${GITHUB_REPOSITORY}/discord-retention-bot:testing |
There was a problem hiding this comment.
Can we remove the whole container branch logic? Does it make sense to build the container on non-main branches but only push it on main instead?
| Discord gateway in order to [send the | ||
| messages](https://discord.com/developers/docs/resources/channel#create-message) | ||
| that the test deletes (otherwise, you'll see a 40001 Unauthorized JSON error). | ||
| You can do this by just making a quick script that calls |
There was a problem hiding this comment.
Suggested change
| You can do this by just making a quick script that calls | |
| You can do this by making a quick script that calls |
There was a problem hiding this comment.
Could we have the script somewhere in the repository to make things easier?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I tried setting this up with my own discord server, and made some tweaks in the process. I'm not sure which if any of these would be appealing to you, but just in case.
The changes: