Skip to content

Coupling update #57

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 7 commits into
base: master
Choose a base branch
from
Open

Coupling update #57

wants to merge 7 commits into from

Conversation

@julesghub
Copy link
Contributor

@julesghub julesghub commented Jul 7, 2025

  • When Underworld coupling is enabled
    • produce a checkpoint when Badland's tNow == tEnd, i.e. end of uw time step.
    • only use the passed in tEnd from python - ignore .xml file.
  • Use of np.inf to force some processes to not occur in time loop.
  • Simplification of variable names in run_to_time()

julesghub and others added 7 commits April 9, 2025 10:52
@julesghub
Update xmlParser.py
2bac1ac 
Add a flag to toggle if we force a final strata call in badlands (only during the Underworld coupling) or not. For some models this seems helpful, for others it doesn't. More testing is required.

For now I am adding a flag and default setting it to false.
@julesghub
Update model.py
b58cf09 
Adding logic to build strata or not.
@julesghub
Update meson.build
4954b5f 
updating version to 2.3.1
@julesghub
Update pyproject.toml
5e076fd 
Update version to 2.3.1
@julesghub
updates for tEnd, always override if use udw
b6bd00e
@julesghub
Using np.inf for switching off processes in time loop.
91f7e5f 
* Previously `self.next_process = self.input.tEnd+1.0e5` was used.
This was causing issues when UW coupling. This change should be fix it.

* Change var names - easier to read
@julesghub
Remove udw-force-final-strata xml tag, no longer needed
7c8d1e3
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@julesghub