sdk-core, node: attribute validation #296
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
konraddysput
requested changes
Oct 8, 2024
| @@ -418,4 +420,51 @@ export abstract class BacktraceCoreClient< | |||
| private static destroy() { | |||
| this._instance = undefined; | |||
| } | |||
|
|
|||
| private validateAttributes() { | |||
| function isNotEmptyString(v: unknown) { | |||
There was a problem hiding this comment.
we're introducing a nice way to validate attributes, but in our scenario, we don't need such complexity. What we can do is just simply test if those two attributes are defined. Based on what we want to verify and how easily we can achieve that, wouldn't it be better if we keep the smallest/simplest solution for now?
There was a problem hiding this comment.
how would you do this more "easily"?
There was a problem hiding this comment.
just simply
const attributes = this.attributeManager.ger()
const validAttributes = !!attributes["application"] && !!attributes["application.version"]
konraddysput
approved these changes
Oct 8, 2024
perf2711
force-pushed
the
feature/attribute-validation
branch
from
6a5b22b to
81a438f
Compare
konraddysput
approved these changes
Oct 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds attribute validation on initialize, which checks the following attributes:
applicationapplication.versionThis also removes the check from
node.