Update CPU, Architecture and OSInfo system attributes #154
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add OSInfo name, version and buildNumber Add CPU/Device architecture Fix uname machine and model attributes Add isSimulator attribute
konraddysput
requested changes
Mar 31, 2025
Comment on lines
107
to
108
| result["device.arch"] = CPU.architecture() | ||
| result["cpu.arch"] = CPU.architecture() |
There was a problem hiding this comment.
- why both?
- you don't have any caching here - it means this function will do a lot of stuff twice.
There was a problem hiding this comment.
setting both to avoid "Unknown Architecture", device.arch & cpu.arch are the same thing but developers can filter using either one.
| @@ -125,6 +127,33 @@ struct SystemControl { | |||
| return baseAddress.withMemoryRebound(to: T.self, capacity: 1, { $0.pointee }) | |||
| }) | |||
| } | |||
|
|
|||
| static func string(forKeys keys: [Int32]) throws -> String { | |||
There was a problem hiding this comment.
what's the point of the string functioN?
There was a problem hiding this comment.
if we can change the function name it would be great.
konraddysput
approved these changes
Apr 23, 2025
| @@ -125,6 +127,33 @@ struct SystemControl { | |||
| return baseAddress.withMemoryRebound(to: T.self, capacity: 1, { $0.pointee }) | |||
| }) | |||
| } | |||
|
|
|||
| static func string(forKeys keys: [Int32]) throws -> String { | |||
There was a problem hiding this comment.
if we can change the function name it would be great.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds OSInfo name, version and buildNumber
Adds CPU/Device architecture
Fixes Uname .machine and .model attributes
Adds isSimulator attribute
ref: BT-5714