Core Data Concurrency update #151
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rmAndWaitThrowing - Add NSManagedObjectContext extension to handle to capture any thrown error and return the result - Update public Repository methods to use backgroundContext.performAndWaitThrowing - Move fetch/delete logic into private _locked helper - Remove direct off-queue fetch/save calls to fix concurrency rule violations - Add doc comments
- Add NSManagedObjectContextExtensionTests - Expand BacktraceDatabaseTests to add concurrent read/write operations, maxRecordCount and retry count Tests
melekr
commented
Jan 28, 2025
| return result | ||
| } | ||
|
|
||
| // Swift 5 approach |
There was a problem hiding this comment.
swift 5 approach is cleaner
melekr
commented
Jan 28, 2025
| try backgroundContext.save() | ||
| } | ||
| // File storage outside the Core Data backgroundContext (optional concurrency). | ||
| // TODO: Verify AttributesStorage for concurrency |
There was a problem hiding this comment.
Initial verification of AttributesStorage did not reveal any issues.
melekr
changed the title
melekr
commented
Jan 28, 2025
| result = Swift.Result(catching: block) | ||
| } | ||
| guard let outcome = result else { | ||
| throw PerformAndWaitError.blockDidNotRun |
melekr
commented
Jan 28, 2025
| } | ||
|
|
||
| // concurrent reads | ||
| for _ in 1...5 { |
There was a problem hiding this comment.
higher concurrent reads/writes take a lot of time.
konraddysput
approved these changes
Feb 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactors PersistentRepository to safely perform Core Data operations.
Why?
When in concurrency debugging mode
-com.apple.CoreData.ConcurrencyDebug 1; any direct call into the context methods from an unexpected thread or queue immediately triggers a concurrency violation.This requires that a private queue context
.privateQueueConcurrencyTypemust be accessed exclusively through itsperform(_:)orperformAndWait(_:)methods, which schedule all reads/writes on its private serial queue.Changes:
ref: BT-5464