Skip to content

Upgrade PlCrashReporter to the latest version #121

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 7 additions & 12 deletions .github/workflows/test.yml
Original file line number Diff line number Diff line change
@@ -1,36 +1,31 @@
name: Run tests

on:
on:
workflow_dispatch:
push:
branches: [master, release]
pull_request:
branches:
- release
- master
schedule:
- cron: '0 0 * * *'

jobs:

test:
runs-on: macos-latest

strategy:
fail-fast: false
matrix:
platform: [ios, mac, tvos]
platform: [ios, mac, tvos]

steps:
- uses: actions/checkout@v3
- name: Install dependencies
run: sh scripts/install.sh
- name: Run test
run: fastlane ${{ matrix.platform }} tests

pod-lint:
runs-on: macos-latest

steps:
- uses: actions/checkout@v3
- name: Install dependencies
run: sh scripts/install.sh

4 changes: 2 additions & 2 deletions Backtrace.podspec
Original file line number Diff line number Diff line change
Expand Up @@ -31,8 +31,8 @@ Pod::Spec.new do |s|
s.ios.public_header_files = ["Backtrace-iOS/**/*.h*"]
s.osx.public_header_files = ["Backtrace-macOS/**/*.h*"]
s.tvos.public_header_files = ["Backtrace-tvOS/**/*.h*"]

s.dependency "Backtrace-PLCrashReporter", '1.5.3'
s.static_framework = true
s.dependency "PLCrashReporter", '1.11'
s.resources = 'Sources/**/*.xcdatamodeld'

end
134 changes: 67 additions & 67 deletions Backtrace.xcodeproj/project.pbxproj

Large diffs are not rendered by default.

2 changes: 1 addition & 1 deletion Podfile
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@ source 'https://cdn.cocoapods.org/'
# Definitions
def shared_pods
# Define shared CocoaPods here
pod 'Backtrace-PLCrashReporter', '1.5.3'
pod 'PLCrashReporter', '1.11'
end

def shared_test_pods
Expand Down
18 changes: 9 additions & 9 deletions Podfile.lock
Original file line number Diff line number Diff line change
@@ -1,32 +1,32 @@
PODS:
- Backtrace (2.0.0):
- Backtrace-PLCrashReporter (= 1.5.3)
- Backtrace-PLCrashReporter (1.5.3)
- Backtrace (2.0.3):
- PLCrashReporter (= 1.11)
- Nimble (10.0.0)
- PLCrashReporter (1.11.0)
- Quick (5.0.1)

DEPENDENCIES:
- Backtrace (from `./Backtrace.podspec`)
- Backtrace-PLCrashReporter (= 1.5.3)
- Nimble (~> 10.0.0)
- PLCrashReporter (= 1.11)
- Quick (~> 5.0.1)

SPEC REPOS:
trunk:
- Backtrace-PLCrashReporter
- Nimble
- PLCrashReporter
- Quick

EXTERNAL SOURCES:
Backtrace:
:path: "./Backtrace.podspec"

SPEC CHECKSUMS:
Backtrace: 03fbe89e1b5ad4591c6397f9d2836b7fa1f340c8
Backtrace-PLCrashReporter: 71ddeba11834d2bcc3c19f357aaec7bf87131f89
Backtrace: 2044bebde49cf66db6cff1c4619bab653f9de360
Nimble: 5316ef81a170ce87baf72dd961f22f89a602ff84
PLCrashReporter: 7a9dff14a23ba5d2e28c6160f0bb6fada5e71a8d
Quick: 749aa754fd1e7d984f2000fe051e18a3a9809179

PODFILE CHECKSUM: 38125db93d4963a0e3d3243634d605f11b17d404
PODFILE CHECKSUM: 2b7d3c7f6716bfb4ee9ab8a1ee475ca57c8165e9

COCOAPODS: 1.12.1
COCOAPODS: 1.11.3
4 changes: 0 additions & 4 deletions Sources/Features/Repository/Model/BacktraceReport.swift
Original file line number Diff line number Diff line change
@@ -1,9 +1,5 @@
import Foundation
#if SWIFT_PACKAGE
import CrashReporter
#else
import Backtrace_PLCrashReporter
#endif

/// Model represents single crash report which can be send to Backtrace services.
@objc final public class BacktraceReport: NSObject {
Expand Down
5 changes: 1 addition & 4 deletions Sources/Public/BacktraceCrashReporter.swift
Original file line number Diff line number Diff line change
@@ -1,9 +1,6 @@
import Foundation
#if SWIFT_PACKAGE
import CrashReporter
#else
import Backtrace_PLCrashReporter
#endif


/// A wrapper around `PLCrashReporter`.
@objc public class BacktraceCrashReporter: NSObject {
Expand Down
4 changes: 0 additions & 4 deletions Tests/Mocks/BacktraceClientTests.swift
Original file line number Diff line number Diff line change
Expand Up @@ -2,11 +2,7 @@ import XCTest

import Nimble
import Quick
#if SWIFT_PACKAGE
import CrashReporter
#else
import Backtrace_PLCrashReporter
#endif
@testable import Backtrace

final class BacktraceClientTests: QuickSpec {
Expand Down
Loading