Skip to content

Bt 5584/check for comodification #172

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 17 commits into from
Jun 18, 2025

Conversation

BartoszLitwiniuk
Copy link
Collaborator

@BartoszLitwiniuk BartoszLitwiniuk commented Apr 28, 2025

Summary

This PR fixes a potential ConcurrentModificationException in BacktraceDatabaseContext, which could occur during deletion operations in the BacktraceHandlerThread when context is used by multiple threads.

Key Changes

  • Replaced List with thread-safe collection types where necessary to ensure safe concurrent access.
  • Refactored internal logic to avoid mutating collections during iteration.
  • Added safeguards and checks to prevent runtime exceptions during batch operations.

Impact

  • Prevents crashes caused by concurrent modifications during database record handling.
  • Enhances the robustness and reliability of the SDK in multithreaded environments.

@BartoszLitwiniuk BartoszLitwiniuk marked this pull request as draft April 28, 2025 19:50
@BartoszLitwiniuk BartoszLitwiniuk marked this pull request as ready for review May 5, 2025 18:28
@melekr melekr self-requested a review May 27, 2025 22:34
@BartoszLitwiniuk BartoszLitwiniuk merged commit e950372 into master Jun 18, 2025
3 checks passed
@BartoszLitwiniuk BartoszLitwiniuk deleted the BT-5584/checkForComodification branch June 18, 2025 20:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants