Skip to content

fix: add ordinals tests also fix issue with out of order from ordinal #15

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Aug 1, 2024

Conversation

jrwbabylonlab
Copy link
Collaborator

@jrwbabylonlab jrwbabylonlab commented Jul 31, 2024

The main purpose of this PR is to add the tests for the ordinal logic

  • change the Utxo to UTXO in method name
  • Added the tests
  • Fixed an issue when ordinal service returned response does not follow the same order as the input utxos

The PR is based on the one from @jeremy-babylonlabs https://github.com/babylonchain/staking-api-service/pull/217/files

Copy link
Member

@gitferry gitferry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work!

Copy link
Member

@vitsalis vitsalis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice

@jrwbabylonlab jrwbabylonlab force-pushed the chores/212-additional-ordinals-tests branch from e5e0528 to 39ff672 Compare August 1, 2024 03:07
@jrwbabylonlab jrwbabylonlab mentioned this pull request Aug 1, 2024
@jrwbabylonlab jrwbabylonlab merged commit a020786 into main Aug 1, 2024
8 checks passed
@jrwbabylonlab jrwbabylonlab deleted the chores/212-additional-ordinals-tests branch August 1, 2024 04:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants