Skip to content

SO-6491: Resolve issue with tracking document scores in EsQueryBuilder #1424

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Oct 29, 2025
Merged

SO-6491: Resolve issue with tracking document scores in EsQueryBuilder #1424

merged 2 commits into from
Oct 29, 2025

Conversation

@apeteri
Copy link
Member

@apeteri apeteri commented Oct 17, 2025

@apeteri
fix(index): Make sure that scoring can not be switch off again in...
0105ae9 
...EsQueryBuilder once it has been established that it is needed. This
could happen when two or more NestedPredicates were visited in a single
call to build(Expression).
@apeteri apeteri self-assigned this Oct 17, 2025
@apeteri apeteri added the bug label Oct 17, 2025
@codecov
Copy link

codecov bot commented Oct 17, 2025 •
edited
Loading

Codecov Report

❌ Patch coverage is 97.77778% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 64.42%. Comparing base (b7c2589) to head (aeb8a6f).
⚠️ Report is 3 commits behind head on 9.x.

Files with missing lines Patch % Lines
...b2international/index/es/query/EsQueryBuilder.java 97.77% 1 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff            @@
##                9.x    #1424   +/-   ##
=========================================
  Coverage     64.42%   64.42%           
- Complexity    12806    12807    +1     
=========================================
  Files          1620     1620           
  Lines         57808    57812    +4     
  Branches       5685     5685           
=========================================
+ Hits          37244    37247    +3     
- Misses        18193    18195    +2     
+ Partials       2371     2370    -1

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

cmark
cmark requested changes Oct 19, 2025
View reviewed changes
Copy link
Member

@cmark cmark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we add a low-level unit test to verify this change? 🙇

@apeteri
Copy link
Member Author

apeteri commented Oct 29, 2025

Added in commit aeb8a6f. It fails without the fix in EsQueryBuilder and passes when it is applied.

cmark
cmark approved these changes Oct 29, 2025
View reviewed changes
Copy link
Member

@cmark cmark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🥓

@cmark cmark requested a review from AAAlinaaa October 29, 2025 14:12
@cmark cmark merged commit 0edf495 into 9.x Oct 29, 2025
5 checks passed
@cmark cmark deleted the issue/SO-6491-nested-query-scoring branch October 29, 2025 14:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@cmark cmark cmark approved these changes

@AAAlinaaa AAAlinaaa AAAlinaaa approved these changes

Assignees

@apeteri apeteri

Labels

bug

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@apeteri @cmark @AAAlinaaa