SO-6343: Valueset include designations display bug #1422
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
concept are itirated over
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## 9.x #1422 +/- ##
=========================================
Coverage 64.42% 64.43%
- Complexity 12806 12807 +1
=========================================
Files 1620 1620
Lines 57803 57808 +5
Branches 5685 5685
=========================================
+ Hits 37242 37246 +4
- Misses 18191 18192 +1
Partials 2370 2370 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
cmark
reviewed
Oct 15, 2025
| * Description is preferred in language or dialect | ||
| */ | ||
| PREFERRED(Concepts.REFSET_DESCRIPTION_ACCEPTABILITY_PREFERRED); | ||
| PREFERRED(Concepts.REFSET_DESCRIPTION_ACCEPTABILITY_PREFERRED, "Preferred"); |
There was a problem hiding this comment.
While this is okay for en displays, it might not be okay for others in the future, so I expect some additional improvement here - in a future Snow Owl version - as well to fetch the label of the acceptability from the db instead of hardcoding it here.
cmark
deleted the
fix/SO-6343-valueset-include-designations-display-bug
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://snowowl.atlassian.net/browse/SO-6343