Skip to content

Feat: callback params add request parameter args #3

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jul 25, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -135,8 +135,8 @@ const [createRequest, { hasPending, cancel }] = useRequest(
method: "DELETE",
}),
{
onCompleted: (data, response) => console.info(data, response),
onError: (err) => console.info(err),
onCompleted: (data, response, paramsArgs) => console.info(data, response, paramsArgs),
onError: (err, paramsArgs) => console.info(err, paramsArgs),
},
);
```
Expand Down Expand Up @@ -255,8 +255,8 @@ const [reqState] = useResource(
}),
[],
{
onCompleted: (data, response) => console.info(data, response),
onError: (err) => console.info(err),
onCompleted: (data, response, paramsArgs) => console.info(data, response, paramsArgs),
onError: (err, paramsArgs) => console.info(err, paramsArgs),
},
);
```
Expand Down
11 changes: 9 additions & 2 deletions src/request.ts
Original file line number Diff line number Diff line change
Expand Up @@ -71,12 +71,19 @@ export type RequestCallbackFn<T extends Request> = {
* A callback function that's called when your request successfully completes with zero errors.
* This function is passed the request's result `data` and `response`.
*/
onCompleted?: (data: Payload<T, true>, response: Payload<T>) => void;
onCompleted?: (
data: Payload<T, true>,
response: Payload<T>,
args: Parameters<T>,
) => void;
/**
* A callback function that's called when the request encounters one or more errors.
* This function is passed an `RequestError` object that contains either a networkError object or a `AxiosError`, depending on the error(s) that occurred.
*/
onError?: (err: RequestError<Payload<T>, BodyData<T>>) => void;
onError?: (
err: RequestError<Payload<T>, BodyData<T>>,
args: Parameters<T>,
) => void;
};

/**
Expand Down
4 changes: 2 additions & 2 deletions src/useRequest.ts
Original file line number Diff line number Diff line change
Expand Up @@ -83,14 +83,14 @@ export function useRequest<T extends Request>(
? options.getResponseItem(res as Payload<T>)
: requestConfig.getResponseItem(res)
) as Payload<T, true>;
onCompleted?.(_data, res as Payload<T>);
onCompleted?.(_data, res as Payload<T>, args);
return [_data, res as Payload<T>] as const;
})
.catch((err: AxiosError<Payload<T>, BodyData<T>>) => {
removeCancelToken(_source.token);

const _error = createRequestError(err);
onError?.(_error);
onError?.(_error, args);

throw _error;
});
Expand Down
20 changes: 15 additions & 5 deletions tests/useRequest.test.ts
Original file line number Diff line number Diff line change
Expand Up @@ -32,11 +32,13 @@ describe("useRequest", () => {

test("any type (without `request`)", async () => {
const [createRequest] = useRequest(getAPIFuncs(true).user.anyTypeList, {
onCompleted(data, response) {
onCompleted(data, response, args) {
expectTypeOf(data).toEqualTypeOf<any>();
expectTypeOf(response).toEqualTypeOf<any>();
expectTypeOf(args).toEqualTypeOf<[]>();
expect(data).toStrictEqual(MOCK_DATA_USER_LIST);
expect(response.data).toStrictEqual(MOCK_DATA_USER_LIST);
expect(args).toStrictEqual([]);
},
});

Expand All @@ -52,11 +54,13 @@ describe("useRequest", () => {
const [createRequest] = useRequest(
getAPIFuncs(true).user.anyTypeWithoutGenericityList,
{
onCompleted(data, response) {
onCompleted(data, response, args) {
expectTypeOf(data).toEqualTypeOf<any>();
expectTypeOf(response).toEqualTypeOf<AxiosResponse<any>>();
expectTypeOf(args).toEqualTypeOf<[]>();
expect(data).toStrictEqual(MOCK_DATA_USER_LIST);
expect(response.data).toStrictEqual(MOCK_DATA_USER_LIST);
expect(args).toStrictEqual([]);
},
},
);
Expand Down Expand Up @@ -217,11 +221,13 @@ describe("useRequest", () => {
}),
{
instance: _instance,
onCompleted: (d, r) => {
onCompleted: (d, r, args) => {
expect(d).toBeUndefined();
expectTypeOf(d).toMatchTypeOf<undefined>();
expect(r).toStrictEqual(mockItem);
expectTypeOf(r).toMatchTypeOf<MockDataUserItem | undefined>();
expectTypeOf(args).toMatchTypeOf<[string]>();
expect(args).toStrictEqual([TARGET_ID]);
},
},
);
Expand Down Expand Up @@ -264,7 +270,7 @@ describe("useRequest", () => {
{
instance: _instance,
getResponseItem: _getResponseItem,
onCompleted: (d, r) => {
onCompleted: (d, r, args) => {
expect(d).toStrictEqual(mockItem);
expectTypeOf(d).toMatchTypeOf<MockDataUserItem | undefined>();
expect(r).toStrictEqual({
Expand All @@ -273,6 +279,8 @@ describe("useRequest", () => {
message: "OK",
});
expectTypeOf(r).toMatchTypeOf<_MyRes<MockDataUserItem> | undefined>();
expectTypeOf(args).toMatchTypeOf<[string]>();
expect(args).toStrictEqual([TARGET_ID]);
},
},
);
Expand Down Expand Up @@ -313,14 +321,16 @@ describe("useRequest", () => {
{
instance: _instance,
getResponseItem: _getResponseItem,
onCompleted: (d, r) => {
onCompleted: (d, r, args) => {
// custom `data` value
expect(d).toStrictEqual(mockItem?.name);
expectTypeOf(d).toMatchTypeOf<string | undefined>();
expect(r.data).toStrictEqual(mockItem);
expectTypeOf(r).toMatchTypeOf<
AxiosResponse<MockDataUserItem> | undefined
>();
expectTypeOf(args).toMatchTypeOf<[string]>();
expect(args).toStrictEqual([TARGET_ID]);
},
},
);
Expand Down
13 changes: 9 additions & 4 deletions tests/useResource.test.ts
Original file line number Diff line number Diff line change
Expand Up @@ -21,14 +21,17 @@ describe("useResource", () => {
setup() {
const id = ref("1");
const params = computed(() => ({ id: unref(id) }));
const [res] = useResource(getAPIFuncs(true).user.get, [params], {
onCompleted: (d, r) => {
const reqFn = getAPIFuncs(true).user.get;
const [res] = useResource(reqFn, [params], {
onCompleted: (d, r, a) => {
expectTypeOf(d).toEqualTypeOf<MockDataUserItem | undefined>();
expectTypeOf(r).toEqualTypeOf<AxiosResponse<MockDataUserItem>>();
expectTypeOf(a).toEqualTypeOf<Parameters<typeof reqFn>>();

const _item = MOCK_DATA_USER_LIST.find((i) => i.id === unref(id));
expect(d).toStrictEqual(_item);
expect(r.data).toStrictEqual(_item);
expect(a).toStrictEqual([{ id: unref(id) }]);
},
});

Expand Down Expand Up @@ -86,9 +89,10 @@ describe("useResource", () => {
defineComponent({
setup() {
const [res] = useResource(getAPIFuncs(true).user.anyTypeList, false, {
onCompleted: (d, r) => {
onCompleted: (d, r, a) => {
expectTypeOf(d).toEqualTypeOf<any>();
expectTypeOf(r).toEqualTypeOf<any>();
expectTypeOf(a).toEqualTypeOf<[]>();
},
});

Expand All @@ -107,9 +111,10 @@ describe("useResource", () => {
getAPIFuncs(true).user.anyTypeWithoutGenericityList,
false,
{
onCompleted: (d, r) => {
onCompleted: (d, r, a) => {
expectTypeOf(d).toEqualTypeOf<any>();
expectTypeOf(r).toEqualTypeOf<AxiosResponse<any>>();
expectTypeOf(a).toEqualTypeOf<[]>();
},
},
);
Expand Down
Loading