Fix: Expose datasets::model::table::* #244
bahloci.yaml
on: pull_request
Matrix: test
Publish on crates.io
0s
Annotations
9 errors and 32 warnings
|
`iter` method without an `IntoIterator` impl for `&Row<'table>`:
src/datasets/model/table.rs#L363
error: `iter` method without an `IntoIterator` impl for `&Row<'table>`
--> src/datasets/model/table.rs:363:5
|
363 | / pub fn iter(&self) -> FieldIter<'table> {
364 | | FieldIter {
365 | | table: self.table,
366 | | row: self.row,
... |
369 | | }
| |_____^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#iter_without_into_iter
help: consider implementing `IntoIterator` for `&Row<'table>`
|
338 +
339 + impl IntoIterator for &Row<'table> {
340 + type Item = std::option::Option<&serde_json::Value>;
341 + type IntoIter = datasets::model::table::FieldIter<'table>;
342 + fn into_iter(self) -> Self::IntoIter {
343 + self.iter()
344 + }
345 + }
|
|
|
this method could have a `#[must_use]` attribute:
src/datasets/model/table.rs#L353
error: this method could have a `#[must_use]` attribute
--> src/datasets/model/table.rs:353:5
|
353 | pub fn get(&self, column: usize) -> Option<&JsonValue> {
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: add the attribute: `#[must_use] pub fn get(&self, column: usize) -> Option<&JsonValue>`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#must_use_candidate
|
|
this method could have a `#[must_use]` attribute:
src/datasets/model/table.rs#L340
error: this method could have a `#[must_use]` attribute
--> src/datasets/model/table.rs:340:5
|
340 | pub fn get_field(&self, field: &str) -> Option<&JsonValue> {
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: add the attribute: `#[must_use] pub fn get_field(&self, field: &str) -> Option<&JsonValue>`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#must_use_candidate
|
|
`iter` method without an `IntoIterator` impl for `&Table`:
src/datasets/model/table.rs#L286
error: `iter` method without an `IntoIterator` impl for `&Table`
--> src/datasets/model/table.rs:286:5
|
286 | / pub fn iter(&self) -> RowIter {
287 | | RowIter {
288 | | table: self,
289 | | row: 0,
290 | | }
291 | | }
| |_____^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#iter_without_into_iter
= note: `#[deny(clippy::iter_without_into_iter)]` implied by `#[deny(clippy::pedantic)]`
help: consider implementing `IntoIterator` for `&Table`
|
229 +
230 + impl IntoIterator for &Table {
231 + type Item = datasets::model::table::Row<'_>;
232 + type IntoIter = datasets::model::table::RowIter<'_>;
233 + fn into_iter(self) -> Self::IntoIter {
234 + self.iter()
235 + }
236 + }
|
|
|
this method could have a `#[must_use]` attribute:
src/datasets/model/table.rs#L286
error: this method could have a `#[must_use]` attribute
--> src/datasets/model/table.rs:286:5
|
286 | pub fn iter(&self) -> RowIter {
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: add the attribute: `#[must_use] pub fn iter(&self) -> RowIter`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#must_use_candidate
|
|
this method could have a `#[must_use]` attribute:
src/datasets/model/table.rs#L277
error: this method could have a `#[must_use]` attribute
--> src/datasets/model/table.rs:277:5
|
277 | pub fn get_row(&self, row: usize) -> Option<Row> {
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: add the attribute: `#[must_use] pub fn get_row(&self, row: usize) -> Option<Row>`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#must_use_candidate
= note: `#[deny(clippy::must_use_candidate)]` implied by `#[deny(clippy::pedantic)]`
|
|
struct `Table` has a public `len` method, but no `is_empty` method:
src/datasets/model/table.rs#L272
error: struct `Table` has a public `len` method, but no `is_empty` method
--> src/datasets/model/table.rs:272:5
|
272 | pub fn len(&self) -> usize {
| ^^^^^^^^^^^^^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_without_is_empty
note: the lint level is defined here
--> src/lib.rs:37:5
|
37 | clippy::all,
| ^^^^^^^^^^^
= note: `#[deny(clippy::len_without_is_empty)]` implied by `#[deny(clippy::all)]`
|
|
unnecessary semicolon:
src/client.rs#L329
error: unnecessary semicolon
--> src/client.rs:329:10
|
329 | };
| ^ help: remove
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_semicolon
note: the lint level is defined here
--> src/lib.rs:40:5
|
40 | clippy::pedantic,
| ^^^^^^^^^^^^^^^^
= note: `#[deny(clippy::unnecessary_semicolon)]` implied by `#[deny(clippy::pedantic)]`
|
|
Clippy check
Clippy had exited with the 101 exit code
|
|
Rustfmt check
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
|
|
Rustfmt check
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
|
|
Rustfmt check
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
|
|
Rustfmt check
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
|
|
Build examples
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
|
|
Build examples
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
|
|
Build examples
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
|
|
Build examples
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
|
|
Run tests with Tokio on development:
tests/datasets.rs#L163
use of deprecated method `axiom_rs::datasets::Client::<'client>::info`: The info method will go away in the future, but come back in a different version.
|
|
Run tests with Tokio on development
`axiom-rs` (test "datasets") generated 1 warning
|
|
Run tests with Tokio on development
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
|
|
Run tests with Tokio on development
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
|
|
Run tests with Tokio on development
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
|
|
Run tests with Tokio on development
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
|
|
Run tests with Tokio on staging
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
|
|
Run tests with Tokio on staging
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
|
|
Run tests with Tokio on staging
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
|
|
Run tests with Tokio on staging
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
|
|
Run tests with Tokio on staging:
tests/datasets.rs#L163
use of deprecated method `axiom_rs::datasets::Client::<'client>::info`: The info method will go away in the future, but come back in a different version.
|
|
Run tests with Tokio on staging
`axiom-rs` (test "datasets") generated 1 warning
|
|
Run tests with async-std on development
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
|
|
Run tests with async-std on development
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
|
|
Run tests with async-std on development
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
|
|
Run tests with async-std on development
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
|
|
Run tests with async-std on development:
tests/datasets.rs#L163
use of deprecated method `axiom_rs::datasets::Client::<'client>::info`: The info method will go away in the future, but come back in a different version.
|
|
Run tests with async-std on development
`axiom-rs` (test "datasets") generated 1 warning
|
|
Run tests with async-std on staging:
tests/datasets.rs#L163
use of deprecated method `axiom_rs::datasets::Client::<'client>::info`: The info method will go away in the future, but come back in a different version.
|
|
Run tests with async-std on staging
`axiom-rs` (test "datasets") generated 1 warning
|
|
Run tests with async-std on staging
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
|
|
Run tests with async-std on staging
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
|
|
Run tests with async-std on staging
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
|
|
Run tests with async-std on staging
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
|