Skip to content

Conversation

@renovate
Copy link
Contributor

@renovate renovate bot commented Dec 20, 2024

This PR contains the following updates:

Package Change Age Confidence
systeminformation (source) 5.22.0 -> 5.23.8 age confidence

GitHub Vulnerability Alerts

CVE-2024-56334

Summary

The SSID is not sanitized when before it is passed as a parameter to cmd.exe in the getWindowsIEEE8021x function. This means that malicious content in the SSID can be executed as OS commands.

Details

I have exploited this vulnerability in a Windows service using version 5.22.11 of the module, to escalate privileges (in an environment where I am authorized to do so). However, as far as I can see from the code, it is still present in master branch at time of writing, on line 403/404 of network.js.

The SSID is obtained from netsh wlan show interface ... in getWindowsWirelessIfaceSSID, and then passed to cmd.exe /d /s /c "netsh wlan show profiles ... in getWindowsIEEE8021x, without sanitization.

PoC

First, the command injection payload should be included in the connected Wi-Fi SSID. For example create hotspot on mobile phone or other laptop, set SSID to payload, connect to it with victim Windows system. Two example SSID's to demonstrate exploitation are below.

Demonstration to run ping command indefinitely:

a" | ping /t 127.0.0.1 &

Run executable with privileges of the user in which vulnerable function is executed. Chosen executable should should be placed in (assuming system drive is C): C:\a\a.exe.

a" | %SystemDrive%\a\a.exe &

Then, the vulnerable function can be executed on the victim system, for example, using:

const si = require('systeminformation');
si.networkInterfaces((net) => { console.log(net) });

Now the chosen command, PING.exe or a.exe will be run through the cmd.exe command line.

Impact

This vulnerability may enable an attacker, depending on how the package is used, to perform remote code execution or local privilege escalation.


Release Notes

sebhildebrandt/systeminformation (systeminformation)

v5.23.8

Compare Source

v5.23.6

Compare Source

v5.23.5

Compare Source

v5.23.4

Compare Source

v5.23.3

Compare Source

v5.23.2

Compare Source

v5.23.1

Compare Source

v5.23.0

Compare Source

v5.22.11

Compare Source

v5.22.10

Compare Source

v5.22.9

Compare Source

v5.22.8

Compare Source

v5.22.7

Compare Source

v5.22.6

Compare Source

v5.22.5

Compare Source

v5.22.4

Compare Source

v5.22.3

Compare Source

v5.22.2

Compare Source

v5.22.1

Compare Source


Configuration

📅 Schedule: Branch creation - "" (UTC), Automerge - At any time (no schedule defined).

🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.

Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 Ignore: Close this PR and you won't be reminded about this update again.


  • If you want to rebase/retry this PR, check this box

This PR was generated by Mend Renovate. View the repository job log.

@renovate renovate bot force-pushed the renovate/npm-systeminformation-vulnerability branch from 0571b38 to 002bc7c Compare January 23, 2025 18:08
@renovate renovate bot force-pushed the renovate/npm-systeminformation-vulnerability branch from 002bc7c to ebac6d1 Compare April 24, 2025 10:27
@renovate renovate bot force-pushed the renovate/npm-systeminformation-vulnerability branch from ebac6d1 to f96e680 Compare May 28, 2025 10:13
@renovate renovate bot force-pushed the renovate/npm-systeminformation-vulnerability branch from f96e680 to 653d23d Compare June 22, 2025 15:12
@renovate renovate bot force-pushed the renovate/npm-systeminformation-vulnerability branch from 653d23d to be1a2a4 Compare July 2, 2025 18:00
@renovate renovate bot force-pushed the renovate/npm-systeminformation-vulnerability branch from be1a2a4 to 2af765d Compare August 31, 2025 13:03
@renovate renovate bot force-pushed the renovate/npm-systeminformation-vulnerability branch from 2af765d to 1b40246 Compare September 25, 2025 18:25
@renovate renovate bot changed the title fix(deps): update dependency systeminformation to v5.23.8 [security] chore(deps): update dependency systeminformation to v5.23.8 [security] Sep 25, 2025
@renovate renovate bot force-pushed the renovate/npm-systeminformation-vulnerability branch from 1b40246 to f27b4bf Compare October 21, 2025 09:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant