fix: Format response text from server in example client implementation #109
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- `String(result)` often ends up calling down to toString on the object. When there is a large JSON object, it ends up with `object Object` - This formats this, attempting to stringify objects, or eventually calling back down to String(text)
|
Thank you for the fix! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
String(result)often ends up calling down to toString on the object. When there is a large JSON object, it ends up withobject ObjectIssue #, if available:
Description of changes:
I was using the example here as a reference for implementing my own client, inside another Lambda function. The MCP Server it was calling was returning a large JSON object, which this client ends up parsing as
[object Object].This change formats various possibilities.
I know this is an example of a chat client here, but wanted to propose this, in case anyone else uses this as reference for their own clients.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.