fix(ts): disable tree shaking for aws sdk v3 when not external due to rolldown bug #327
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reason for this change
Rolldown tree-shakes the AWS SDK too aggressively and removes required code. See the following issue for details: rolldown/rolldown#6513
Description of changes
This change ensures that any bundles targeting lambda are generated with the AWS SDK as external as it's provided by the lambda runtime (
ts#smithy-api
andts#trpc-api
were missing this -ts#lambda-function
already had this set).For projects which don't target lambda and don't externalise the AWS SDK (only
ts#mcp-server
right now which runs on agentcore runtime), we disable tree shaking for AWS SDK dependencies via a custom plugin.Additionally set
platform
tonode
by default in rolldown config - when omitted rolldown defaults to browser but we're only using it for bundles targeting the node runtime.Description of how you validated changes
Unit tests. Deployed a
ts#mcp-server
which uses the dynamodb client.Checklist
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license