-
Notifications
You must be signed in to change notification settings - Fork 219
Adding more parameters to the sweeper combinations for FUSE threads and objects. #1592
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Adding more parameters to the sweeper combinations for FUSE threads and objects. #1592
Conversation
…nd objects. Signed-off-by: Tadiwa Magwenzi <tadiwaom@amazon.com>
params: | ||
'benchmarks.fio.direct_io': false, true | ||
'benchmarks.fio.fuse_threads': 16 #1, 64 | ||
'benchmarks.fio.fuse_threads': 1, 16, 64 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It'd be good to restrict the combinations of app workers and fuse_threads as we don't care about all combinations of these values. Can we specify them as a pair instead?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I had the same suggestion at some point too, but it makes me wonder how feasible it is to maintain and extend a coupled setup like that.
- Does it become more error-prone or something that requires context to update every time?
- Do we really need an increased number of combinations and consequently a stricter sweeper (in mainline), given we only plot 1 object and 16 objects on day-to-day basis; or should this be something one can play around with during investigations on their machine?
- Will our Jupyter notebooks continue to work with some values/combinations of threads/app_workers missing?
Adding more parameters to the sweeper combinations for FUSE threads and application workers
What changed and why?
Expanded the parameter combinations in the benchmark sweeper configuration to include more values for testing:
application_workers
: Added values 4 and 64 to the existing 1, 16 combinationfuse_threads
: Added values 1 and 64 to the existing 16 valueThis change supports an ongoing investigation that requires testing across a broader range of worker and thread configurations.
Does this change impact existing behavior?
No breaking changes. This only adds additional parameter combinations for benchmarking - existing functionality remains unchanged.
Does this change need a changelog entry? Does it require a version change?
No changelog entry or version change required. This is an internal benchmarking configuration change that doesn't affect the public API or user-facing functionality.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license and I agree to the terms of the Developer Certificate of Origin (DCO).