Add option to use latest directory and add run printing #1586
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
c-hagem
had a problem deploying
to
PR integration tests
GitHub Actions
Failure
c-hagem
had a problem deploying
to
PR integration tests
GitHub Actions
Failure
c-hagem
had a problem deploying
to
PR integration tests
GitHub Actions
Failure
c-hagem
had a problem deploying
to
PR integration tests
GitHub Actions
Failure
c-hagem
had a problem deploying
to
PR integration tests
GitHub Actions
Failure
c-hagem
had a problem deploying
to
PR integration tests
GitHub Actions
Failure
c-hagem
had a problem deploying
to
PR integration tests
GitHub Actions
Failure
c-hagem
had a problem deploying
to
PR integration tests
GitHub Actions
Failure
c-hagem
had a problem deploying
to
PR integration tests
GitHub Actions
Failure
c-hagem
had a problem deploying
to
PR integration tests
GitHub Actions
Failure
c-hagem
had a problem deploying
to
PR integration tests
GitHub Actions
Failure
c-hagem
had a problem deploying
to
PR integration tests
GitHub Actions
Failure
c-hagem
had a problem deploying
to
PR integration tests
GitHub Actions
Failure
c-hagem
had a problem deploying
to
PR integration tests
GitHub Actions
Failure
c-hagem
had a problem deploying
to
PR integration tests
GitHub Actions
Failure
c-hagem
had a problem deploying
to
PR integration tests
GitHub Actions
Failure
c-hagem
had a problem deploying
to
PR integration tests
GitHub Actions
Failure
c-hagem
had a problem deploying
to
PR integration tests
GitHub Actions
Failure
c-hagem
had a problem deploying
to
PR integration tests
GitHub Actions
Failure
c-hagem
had a problem deploying
to
PR integration tests
GitHub Actions
Failure
c-hagem
had a problem deploying
to
PR integration tests
GitHub Actions
Failure
c-hagem
force-pushed
the
autogroup-latest-option
branch
from
12e26af to
b9172e4
Compare
c-hagem
had a problem deploying
to
PR integration tests
GitHub Actions
Failure
c-hagem
had a problem deploying
to
PR integration tests
GitHub Actions
Failure
c-hagem
had a problem deploying
to
PR integration tests
GitHub Actions
Failure
c-hagem
had a problem deploying
to
PR integration tests
GitHub Actions
Failure
c-hagem
had a problem deploying
to
PR integration tests
GitHub Actions
Failure
c-hagem
had a problem deploying
to
PR integration tests
GitHub Actions
Failure
c-hagem
had a problem deploying
to
PR integration tests
GitHub Actions
Failure
c-hagem
had a problem deploying
to
PR integration tests
GitHub Actions
Failure
c-hagem
temporarily deployed
to
PR integration tests
GitHub Actions
Inactive
Adds two features to the autogroup.py script, namely - the possibility to print either the numbers of all runs of a category (ordered descendingly by throughput), when specifying `--runs=all`, or just to print max, median and min run numbers `--runs=tri` - makes default order of throughputs consistent with sorting order if runs are specified - adds possibility to use print the latest run (by default latest is inferred from the run number, but can also be switched to modification time). Additionally, with `--latest=K` the k-th latest run acording to the specified order is picked. Signed-off-by: Christian Hagemeier <chagem@amazon.com>
Signed-off-by: Christian Hagemeier <chagem@amazon.com>
Signed-off-by: Christian Hagemeier <chagem@amazon.com>
Signed-off-by: Christian Hagemeier <chagem@amazon.com>
c-hagem
force-pushed
the
autogroup-latest-option
branch
from
ac44bf2 to
137139b
Compare
c-hagem
had a problem deploying
to
PR integration tests
GitHub Actions
Failure
c-hagem
had a problem deploying
to
PR integration tests
GitHub Actions
Failure
c-hagem
had a problem deploying
to
PR integration tests
GitHub Actions
Failure
c-hagem
had a problem deploying
to
PR integration tests
GitHub Actions
Failure
c-hagem
had a problem deploying
to
PR integration tests
GitHub Actions
Failure
c-hagem
had a problem deploying
to
PR integration tests
GitHub Actions
Failure
c-hagem
had a problem deploying
to
PR integration tests
GitHub Actions
Failure
c-hagem
had a problem deploying
to
PR integration tests
GitHub Actions
Failure
c-hagem
had a problem deploying
to
PR integration tests
GitHub Actions
Failure
c-hagem
had a problem deploying
to
PR integration tests
GitHub Actions
Failure
c-hagem
had a problem deploying
to
PR integration tests
GitHub Actions
Failure
c-hagem
had a problem deploying
to
PR integration tests
GitHub Actions
Failure
c-hagem
had a problem deploying
to
PR integration tests
GitHub Actions
Failure
c-hagem
had a problem deploying
to
PR integration tests
GitHub Actions
Failure
c-hagem
had a problem deploying
to
PR integration tests
GitHub Actions
Failure
c-hagem
had a problem deploying
to
PR integration tests
GitHub Actions
Failure
c-hagem
had a problem deploying
to
PR integration tests
GitHub Actions
Failure
c-hagem
had a problem deploying
to
PR integration tests
GitHub Actions
Failure
c-hagem
had a problem deploying
to
PR integration tests
GitHub Actions
Failure
c-hagem
had a problem deploying
to
PR integration tests
GitHub Actions
Failure
c-hagem
had a problem deploying
to
PR integration tests
GitHub Actions
Failure
muddyfish
reviewed
Aug 29, 2025
|
|
||
| # Add run numbers column if requested | ||
| if args.runs: | ||
| sorted_by_throughput = sorted(zip(throughputs, run_numbers), reverse=True) |
There was a problem hiding this comment.
Isn't zip(throughputs, run_numbers) equivalent to throughput_data?
| selected_runs = [max_run, median_run, min_run] | ||
| # Remove duplicates while preserving order using dict.fromkeys() | ||
| # (works in python > 3.7) | ||
| unique_runs = list(dict.fromkeys(selected_runs)) |
There was a problem hiding this comment.
I think your previous approach was more readable 😅
Perhaps just move it to a function instead?
|
|
||
| row.append(",".join(unique_runs)) | ||
| else: | ||
| all_runs = [r for _, r in sorted_by_throughput] |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds two features to the autogroup.py script, namely
--runs=all, or just to print max, median and min run numbers--runs=rep(for representative)Only changes behaviour of the benchmarking autogroup script, so no Changelog entries / version bumps needed.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license and I agree to the terms of the Developer Certificate of Origin (DCO).