Skip to content

Conversation

15skumar
Copy link
Contributor

This PR is not to be merged, it is for running the CI benchmarks with the compile time flag for OTel integration enabled as well as the CLI parameter enabled to publish metrics to the otlp endpoint.
This is to check the performance impact of publishing metrics.


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license and I agree to the terms of the Developer Certificate of Origin (DCO).

15skumar and others added 4 commits August 12, 2025 10:49
No impact on existing behavior, only adding on to existing behavior.
Note that we have removed publishing of Histogram metrics for now while
we figure out how to integrate the percentiles into CloudWatch. All
other metrics, i.e. counters and gauges are published.

This PR adds a CLI argument which enables users to run Mountpoint with
the functionality of publishing metrics to a specified endpoint,.

Added functionality:
Run Mountpoint with `--log-metrics-otlp http://localhost:4318` flag to
enable publishing metrics to port 4318 (otlp port)
Optionally you can also specify the exporting interval with the
`--log-metrics-otlp-interval` flag.

To verify the implementation I ran a docker container running the
OpenTelemetry Collector at the default port, and ran Mountpoint with the
new flag with endpoint specified.
I verified that the Mountpoint metrics were visible in the collector
logs. Here is a screenshot of an example Mountpoint metric collected at
the endpoint:
<img width="408" alt="Screenshot 2025-06-24 at 17 23 38"
src="https://github.com/user-attachments/assets/a7acfdda-bb85-4595-96ea-633969418b79"
/>

---

By submitting this pull request, I confirm that my contribution is made
under the terms of the Apache 2.0 license and I agree to the terms of
the [Developer Certificate of Origin
(DCO)](https://developercertificate.org/).

---------

Signed-off-by: Shivangi Kumar <shivyk@amazon.com>
Co-authored-by: Shivangi Kumar <shivyk@amazon.com>
Signed-off-by: Shivangi Kumar <shivyk@amazon.com>
Signed-off-by: Shivangi Kumar <shivyk@amazon.com>
Signed-off-by: Shivangi Kumar <shivyk@amazon.com>
@15skumar 15skumar temporarily deployed to PR integration tests August 14, 2025 16:11 — with GitHub Actions Inactive
@15skumar 15skumar temporarily deployed to PR integration tests August 14, 2025 16:11 — with GitHub Actions Inactive
@15skumar 15skumar temporarily deployed to PR integration tests August 14, 2025 16:11 — with GitHub Actions Inactive
@15skumar 15skumar temporarily deployed to PR integration tests August 14, 2025 16:11 — with GitHub Actions Inactive
@15skumar 15skumar temporarily deployed to PR integration tests August 14, 2025 16:11 — with GitHub Actions Inactive
@15skumar 15skumar temporarily deployed to PR integration tests August 14, 2025 16:11 — with GitHub Actions Inactive
@15skumar 15skumar temporarily deployed to PR integration tests August 14, 2025 16:11 — with GitHub Actions Inactive
@15skumar 15skumar temporarily deployed to PR integration tests August 14, 2025 16:11 — with GitHub Actions Inactive
@15skumar 15skumar temporarily deployed to PR integration tests August 14, 2025 16:11 — with GitHub Actions Inactive
@15skumar 15skumar temporarily deployed to PR integration tests August 14, 2025 16:11 — with GitHub Actions Inactive
@15skumar 15skumar temporarily deployed to PR integration tests August 14, 2025 16:11 — with GitHub Actions Inactive
@15skumar 15skumar temporarily deployed to PR integration tests August 14, 2025 16:11 — with GitHub Actions Inactive
@15skumar 15skumar temporarily deployed to PR integration tests August 14, 2025 16:11 — with GitHub Actions Inactive
@15skumar 15skumar temporarily deployed to PR integration tests August 14, 2025 16:11 — with GitHub Actions Inactive
@15skumar 15skumar temporarily deployed to PR integration tests August 14, 2025 16:11 — with GitHub Actions Inactive
@15skumar 15skumar temporarily deployed to PR integration tests August 14, 2025 16:11 — with GitHub Actions Inactive
@15skumar 15skumar had a problem deploying to PR integration tests August 14, 2025 16:11 — with GitHub Actions Failure
@15skumar 15skumar temporarily deployed to PR integration tests August 14, 2025 16:11 — with GitHub Actions Inactive
@15skumar 15skumar temporarily deployed to PR integration tests August 14, 2025 16:11 — with GitHub Actions Inactive
@15skumar 15skumar temporarily deployed to PR integration tests August 14, 2025 16:11 — with GitHub Actions Inactive
@15skumar 15skumar temporarily deployed to PR integration tests August 14, 2025 16:11 — with GitHub Actions Inactive
@15skumar 15skumar added the performance PRs to run benchmarks on label Aug 14, 2025
@15skumar 15skumar temporarily deployed to PR integration tests August 14, 2025 16:25 — with GitHub Actions Inactive
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

performance PRs to run benchmarks on

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant