generated from amazon-archives/__template_Apache-2.0
-
Notifications
You must be signed in to change notification settings - Fork 219
Clean up the cache sub-directory in a background thread #1569
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
unexge
wants to merge
4
commits into
awslabs:main
Choose a base branch
from
unexge:push-zmwuoqtvxxxo
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mountpoint tries to clean up the cache sub-directory during startup and exit in a blocking manner. This causes a cold start on Mountpoint if the cache sub-directory is not cleaned up in exit (e.g., if it's forcefully terminated) and if the cache sub-directory contains lots of files. This change updates the clean up logic to do a rename first in the current thread to ensure Mountpoint starts with a fresh cache folder, and then spawns a detached background thread to remove the old cache directory. The cache sub-directory is still cleaned up in a blocking manner in the current thread during exit. Signed-off-by: Burak Varlı <burakvar@amazon.co.uk>
70a0c98
to
536205f
Compare
Signed-off-by: Burak Varlı <burakvar@amazon.co.uk>
Signed-off-by: Burak Varlı <burakvar@amazon.co.uk>
Signed-off-by: Burak Varlı <burakvar@amazon.co.uk>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Mountpoint tries to clean up the cache sub-directory during startup and exit in a blocking manner. This causes a cold start on Mountpoint if the cache sub-directory is not cleaned up in exit (e.g., if it's forcefully terminated) and if the cache sub-directory contains lots of files.
This change updates the clean up logic to do a rename first in the current thread to ensure Mountpoint starts with a fresh cache folder, and then spawns a detached background thread to remove the old cache directory. The cache sub-directory is still cleaned up in a blocking manner in the current thread during exit.
Does this change impact existing behavior?
The cache will now be cleaned up in a background thread, this change may:
Does this change need a changelog entry? Does it require a version change?
Probably requires a changelog entry.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license and I agree to the terms of the Developer Certificate of Origin (DCO).