generated from amazon-archives/__template_Apache-2.0
-
Notifications
You must be signed in to change notification settings - Fork 219
Add disk cache to prefetch benchmark #1487
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
dannycjones
wants to merge
2
commits into
awslabs:main
Choose a base branch
from
dannycjones:add-cache-to-prefetch-benchmark
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Add disk cache to prefetch benchmark #1487
dannycjones
wants to merge
2
commits into
awslabs:main
from
dannycjones:add-cache-to-prefetch-benchmark
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Daniel Carl Jones <djonesoa@amazon.com>
Signed-off-by: Daniel Carl Jones <djonesoa@amazon.com>
7dbc290
to
79a29f6
Compare
79a29f6
to
65412ad
Compare
New help output for
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change adds the ability to configure the prefetch benchmark with a disk cache. The configuration for the benchmark is slightly different from the main
mount-s3
CLI - we allow the cache cleanup to be turned off to test warm caches. Additionally, the eviction mechanism is turned off and the cache is unbounded.This patch includes some small refactors, to allow us to share defaults across benchmarks and the main CLI such that they are kept in sync.
It also introduces CLI headings for the help, to make it clearer to users (us) which options relate to which components: S3 client, prefetcher, etc..
Does this change impact existing behavior?
Benchmark change only.
Does this change need a changelog entry? Does it require a version change?
No, benchmark change only.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license and I agree to the terms of the Developer Certificate of Origin (DCO).