Skip to content

Add support for Direct Lambda Resolver event format #1015

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Jul 11, 2025

Conversation

46ki75
Copy link
Contributor

@46ki75 46ki75 commented Jul 11, 2025

📬 Issue #, if available:

✍️ Description of changes:

🔏 By submitting this pull request

  • I confirm that I've ran cargo +nightly fmt.
  • I confirm that I've ran cargo clippy --fix.
  • I confirm that I've made a best effort attempt to update all relevant documentation.
  • I confirm that my contribution is made under the terms of the Apache 2.0 license.

@46ki75
Copy link
Contributor Author

46ki75 commented Jul 11, 2025

I ran cargo clippy --fix as requested.

Some unrelated changes were suggested outside the scope of this PR, but I did not commit those.
Only the code I added in this PR was modified.

Unstaged changes from cargo clippy --fix
❯ git status
On branch feature/event-appsync-vtl
Your branch is up to date with 'origin/feature/event-appsync-vtl'.

Changes not staged for commit:
  (use "git add <file>..." to update what will be committed)
  (use "git restore <file>..." to discard changes in working directory)
        modified:   lambda-events/src/encodings/http.rs
        modified:   lambda-events/src/event/dynamodb/attributes.rs
        modified:   lambda-events/src/event/sns/mod.rs
        modified:   lambda-http/src/deserializer.rs
        modified:   lambda-runtime/src/runtime.rs

no changes added to commit (use "git add" and/or "git commit -a")

@46ki75 46ki75 force-pushed the feature/event-appsync-vtl branch from b527837 to 16106ca Compare July 11, 2025 19:59
Copy link
Contributor

@jlizen jlizen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mostly looks good, but had some questions.

I see you removed the groups field from AppSyncCognitoIdentity due to semver breakage. If the model needs updating, we can certainly bump the minor version.

But, I don't see the groups field in the docs reference anyway? Do you have more context on it if you'd like to keep it in?

Copy link
Contributor

@jlizen jlizen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution!

I'll get the ball rolling on a new release, will aim for sometime next week.

@jlizen jlizen merged commit ee2e0d2 into awslabs:main Jul 11, 2025
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add Direct Lambda Resolver Event Format (AppSync) to Event Definitions
2 participants