Skip to content

fix(ci): cut run-integration-test.yml over to "mlugg/setup-zig@v2", clippy fixes #1005

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jul 7, 2025

Conversation

jlizen
Copy link
Contributor

@jlizen jlizen commented Jun 30, 2025

✍️ Description of changes:

Run-integ setup-zig action change

We had pinned back our cargo-lambda version due to CI failures. Ref: #989

The cargo-lambda issue was closed because it was determined that the issue had to do with the underlying zig install. essentially, you need libraries available, not just the binary. Ref: cargo-lambda/cargo-lambda#856 (comment)

In the process of cleaning up, I noticed we were using an archived action. Cutting us over to the modern one.

Unfortunately, this wasn't sufficient to fix the issue, sample run, so leaving us pinned for now. I cut a backlog: #1006

Clippy fixes

The new clippy turned inline variable enforcement in fmt strings from pedantic to warn, so our CI started failing. Fixing.

🔏 By submitting this pull request

  • I confirm that I've ran cargo +nightly fmt.
  • I confirm that I've ran cargo clippy --fix.
  • I confirm that I've made a best effort attempt to update all relevant documentation.
  • I confirm that my contribution is made under the terms of the Apache 2.0 license.

@jlizen jlizen force-pushed the main branch 8 times, most recently from 09c7c3a to 252c25f Compare June 30, 2025 17:47
@jlizen jlizen self-assigned this Jun 30, 2025
@jlizen jlizen assigned jlizen and unassigned jlizen Jun 30, 2025
@jlizen jlizen self-assigned this Jun 30, 2025
@jlizen jlizen marked this pull request as ready for review June 30, 2025 17:52
@jlizen jlizen marked this pull request as draft June 30, 2025 17:53
@jlizen jlizen changed the title fix(ci): cut run-integration-test.yml over to "mlugg/setup-zig@v2" fix(ci): cut run-integration-test.yml over to "mlugg/setup-zig@v2", clippy fixes Jun 30, 2025
@jlizen jlizen marked this pull request as ready for review June 30, 2025 19:23
@jlizen jlizen removed their assignment Jun 30, 2025
Copy link
Contributor

@bnusunny bnusunny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jlizen jlizen merged commit 2278cea into awslabs:main Jul 7, 2025
26 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants