Skip to content

support ice-lite 2025 #2143

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from
Open

support ice-lite 2025 #2143

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion src/source/PeerConnection/PeerConnection.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1343,6 +1343,7 @@ STATUS setRemoteDescription(PRtcPeerConnection pPeerConnection, PRtcSessionDescr
ENTERS();
STATUS retStatus = STATUS_SUCCESS;
PCHAR remoteIceUfrag = NULL, remoteIcePwd = NULL;
BOOL controlling = FALSE;
UINT32 i, j;
PSessionDescription pSessionDescription;

Expand All @@ -1361,6 +1362,7 @@ STATUS setRemoteDescription(PRtcPeerConnection pPeerConnection, PRtcSessionDescr
NULLABLE_SET_VALUE(pKvsPeerConnection->canTrickleIce, FALSE);

CHK_STATUS(deserializeSessionDescription(pSessionDescription, pSessionDescriptionInit->sdp));
controlling = pKvsPeerConnection->isOffer;

for (i = 0; i < pSessionDescription->sessionAttributesCount; i++) {
if (STRCMP(pSessionDescription->sdpAttributes[i].attributeName, "fingerprint") == 0) {
Expand All @@ -1374,6 +1376,9 @@ STATUS setRemoteDescription(PRtcPeerConnection pPeerConnection, PRtcSessionDescr
} else if (STRCMP(pSessionDescription->sdpAttributes[i].attributeName, "ice-options") == 0 &&
STRSTR(pSessionDescription->sdpAttributes[i].attributeValue, "trickle") != NULL) {
NULLABLE_SET_VALUE(pKvsPeerConnection->canTrickleIce, TRUE);
} else if (STRCMP(pSessionDescription->sdpAttributes[i].attributeName, "ice-lite") == 0) {
// if remote description says "ice-lite" we are always the ice controlling side
controlling = TRUE;
}
}

Expand Down Expand Up @@ -1430,7 +1435,7 @@ STATUS setRemoteDescription(PRtcPeerConnection pPeerConnection, PRtcSessionDescr

// This starts the state machine timer callback that transitions states periodically
CHK_STATUS(iceAgentStartAgent(pKvsPeerConnection->pIceAgent, pKvsPeerConnection->remoteIceUfrag, pKvsPeerConnection->remoteIcePwd,
pKvsPeerConnection->isOffer));
controlling));

if (!pKvsPeerConnection->isOffer) {
CHK_STATUS(setPayloadTypesFromOffer(pKvsPeerConnection->pCodecTable, pKvsPeerConnection->pRtxTable, pSessionDescription));
Expand Down
Loading