Skip to content

Refactor Signaling sources to make Include_i.h independent of libwebsockets #2141

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 5, 2025
Merged

Refactor Signaling sources to make Include_i.h independent of libwebsockets #2141

merged 1 commit into from
Jun 5, 2025

Conversation

vikramdattu
Copy link
Contributor

  • This way, one could write a new CMakeLists.txt, with ApiCalls using different websocket implementation
  • One should simply remove existing Signaling.c and LwsApiCalls.c from compilation and add their own

What was changed?

  • Include_i.h and other SIgnaling files modified to contain libwebsockets dependency to C files

Why was it changed?

  • To make it easier to swap the signaling implementation keeping headers re-usable

vikramdattu
vikramdattu commented May 22, 2025
View reviewed changes
vikramdattu
vikramdattu commented May 22, 2025
View reviewed changes
sirknightj
sirknightj approved these changes May 22, 2025
View reviewed changes
Copy link
Contributor

@sirknightj sirknightj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look good, thanks for all the hard work!

@vikramdattu vikramdattu force-pushed the refactor/make_headers_libwebsockets_independent branch from e90a7c8 to f2be2ca Compare May 23, 2025 06:51
@vikramdattu vikramdattu force-pushed the refactor/make_headers_libwebsockets_independent branch from ffe8a11 to 5fec2e5 Compare June 3, 2025 05:50
@vikramdattu vikramdattu requested a review from sirknightj June 3, 2025 05:51
stefankiesz
stefankiesz approved these changes Jun 5, 2025
View reviewed changes
Copy link
Contributor

@stefankiesz stefankiesz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM once we get CI passing. Thank you for this work!

@vikramdattu
Refactor Signaling sources to make Include_i.h independent of libwe…
cb360ba 
…bsockets

 - This way, one could write a new CMakeLists.txt, with ApiCalls using different websocket implementation
 - One should simply remove existing Signaling.c and LwsApiCalls.c from compilation and add their own
@vikramdattu vikramdattu force-pushed the refactor/make_headers_libwebsockets_independent branch from 5fec2e5 to cb360ba Compare June 5, 2025 11:58
@sirknightj sirknightj merged commit ff16c69 into awslabs:develop Jun 5, 2025
75 of 76 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sirknightj sirknightj sirknightj approved these changes

@stefankiesz stefankiesz stefankiesz approved these changes

@unicornss unicornss Awaiting requested review from unicornss

Assignees
No one assigned
Labels
v1.13.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@vikramdattu @sirknightj @stefankiesz