Support dynamically allocated signaling payload #2140
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- We end up allocating `MAX_SIGNALING_MESSAGE_LEN` per signaling message received. - Not needed, and we can chose to do this allocation dynamically. - For memory constrained devices, this is a huge deal. and would reduce(~couple of 100KBs of) peak memory usage.
sirknightj
reviewed
Jun 3, 2025
| * MAX_SIGNALING_MESSAGE_LEN for each message when only a small payload is needed | ||
| */ | ||
| #ifndef DYNAMIC_SIGNALING_PAYLOAD | ||
| #define DYNAMIC_SIGNALING_PAYLOAD 1 |
There was a problem hiding this comment.
Can we make this a CMake option? (for out of the box builds)
For backwards compatibility, we should have 0/OFF as the default since it requires an application change.
There was a problem hiding this comment.
Example:
amazon-kinesis-video-streams-webrtc-sdk-c/CMakeLists.txt
Lines 131 to 133 in cf817bc
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
MAX_SIGNALING_MESSAGE_LENper signaling message received.What was changed?
Why was it changed?
How was it changed?
What testing was done for the changes?