Skip to content

Increase the signaling message receive buffer size #2126

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
May 7, 2025
Merged

Conversation

sirknightj
Copy link
Contributor

@sirknightj sirknightj commented May 6, 2025

Issue #, if available:

  • We observed the following error message only on Chrome, and only after updating from 135 to 136, with the JS viewer with send video ❌ and send audio ✅ :
2025-05-06 18:33:11.823 WARN    lwsWssCallbackRoutine(): Failed in LWS handling routine with 0x5d000028

This corresponds to:

#define STATUS_SIGNALING_RECEIVED_MESSAGE_LARGER_THAN_MAX_DATA_LEN STATUS_SIGNALING_BASE + 0x00000028
  • We did not observe the issue when both are enabled.

What was changed?

  • Increase the size of the signaling message buffer.

Why was it changed?

  • The buffer was too small. Looking at the release notes, Chrome added support for H.265 and the SDP offer generated by the browser increased in size.

How was it changed?

  • Doubled ~1.83x'd the size of the constant. We can look into optimizing the size in the future.

What testing was done for the changes?

  • Run it locally, which was previously not working and checked that it is able to connect with the JS.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@sirknightj sirknightj changed the title Re Increase the signaling message receive buffer size May 6, 2025
@sirknightj
Copy link
Contributor Author

Also: Bump the user agent in preparation for the next release

Copy link
Contributor

@unicornss unicornss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

unit tests to be tracked separately

@sirknightj sirknightj merged commit 34ef628 into develop May 7, 2025
75 checks passed
sirknightj added a commit that referenced this pull request May 7, 2025
* Add MIPS32 cross compilation, refactor existing cross-compilation jobs (#2091)

* MIPS32 cross compilation, threadpool, and use DRY

* Add the ZLIB changes too

* Address comment

* Add opus sample frame generation GStreamer command to the readme (#2098)

* Add data channel option to the readme (#2099)

* Add data channel option to the readme

* Address comments

* Fixing the SPS/PPS/VPS for the H.265 samples to ensure that Safari playback does not pause. (#2111)

* Upgrade to Ubuntu 22, refactor CI to use DRY, seperate the jobs (#2116)

* Upgrade to Ubuntu 22, refactor CI to use DRY, seperate the jobs

* Additional cleanup

* Fix the uint16 promotion case (#2101)

* Cleaning up stale resources, adjusted logging (#2117)

* Global log level

* Add progress bar and run the deletion script

* Undo git_shallow for non-tagged versions

* Install dependencies for AWS SDK CPP

* Use ubuntu 22 container for the codecov

* Downgrade to Ubuntu 20

* Add CD and change to bash

* Install curl

* Increase history for codecov

* Seperate the steps for generating the report and uploading it

* Configure LWS logs with KVS log level (#2118)

* getNatBehaviorStr: Fix function return value compile error (#2114)

- Following error was seen:
  `In function 'getNatBehaviorStr': NatBehaviorDiscovery.c:385:1: error: control reaches end of non-void function [-Werror=return-type]`
 - Fixed this by returning `NAT_BEHAVIOR_NONE_STR`

* Allow branches named with pattern 'test-pr-*' to trigger the CI (#2120)

* Increase the signaling message receive buffer size (#2126)

* Increase the buffer sizes to accomodate for H.265 support in Chrome

* Bump the project version to 1.12.1

* 2x was too much, make it less

---------

Co-authored-by: Siva Somasundaram <34496097+unicornss@users.noreply.github.com>
Co-authored-by: Vikram Dattu <dattuvikram@gmail.com>
@sirknightj sirknightj deleted the v1.12.1 branch May 7, 2025 20:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants