-
Notifications
You must be signed in to change notification settings - Fork 344
Increase the signaling message receive buffer size #2126
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also: Bump the user agent in preparation for the next release |
unicornss
approved these changes
May 6, 2025
stefankiesz
approved these changes
May 6, 2025
unicornss
reviewed
May 6, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
unit tests to be tracked separately
unicornss
approved these changes
May 6, 2025
stefankiesz
approved these changes
May 6, 2025
sirknightj
added a commit
that referenced
this pull request
May 7, 2025
* Add MIPS32 cross compilation, refactor existing cross-compilation jobs (#2091) * MIPS32 cross compilation, threadpool, and use DRY * Add the ZLIB changes too * Address comment * Add opus sample frame generation GStreamer command to the readme (#2098) * Add data channel option to the readme (#2099) * Add data channel option to the readme * Address comments * Fixing the SPS/PPS/VPS for the H.265 samples to ensure that Safari playback does not pause. (#2111) * Upgrade to Ubuntu 22, refactor CI to use DRY, seperate the jobs (#2116) * Upgrade to Ubuntu 22, refactor CI to use DRY, seperate the jobs * Additional cleanup * Fix the uint16 promotion case (#2101) * Cleaning up stale resources, adjusted logging (#2117) * Global log level * Add progress bar and run the deletion script * Undo git_shallow for non-tagged versions * Install dependencies for AWS SDK CPP * Use ubuntu 22 container for the codecov * Downgrade to Ubuntu 20 * Add CD and change to bash * Install curl * Increase history for codecov * Seperate the steps for generating the report and uploading it * Configure LWS logs with KVS log level (#2118) * getNatBehaviorStr: Fix function return value compile error (#2114) - Following error was seen: `In function 'getNatBehaviorStr': NatBehaviorDiscovery.c:385:1: error: control reaches end of non-void function [-Werror=return-type]` - Fixed this by returning `NAT_BEHAVIOR_NONE_STR` * Allow branches named with pattern 'test-pr-*' to trigger the CI (#2120) * Increase the signaling message receive buffer size (#2126) * Increase the buffer sizes to accomodate for H.265 support in Chrome * Bump the project version to 1.12.1 * 2x was too much, make it less --------- Co-authored-by: Siva Somasundaram <34496097+unicornss@users.noreply.github.com> Co-authored-by: Vikram Dattu <dattuvikram@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
This corresponds to:
What was changed?
Why was it changed?
How was it changed?
Doubled~1.83x'd the size of the constant. We can look into optimizing the size in the future.What testing was done for the changes?
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.