Bugfix: getNatBehavior return #2114
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
👍 Would suggest adding an error log for the new case. Please target |
- Following error was seen: `In function 'getNatBehaviorStr': NatBehaviorDiscovery.c:385:1: error: control reaches end of non-void function [-Werror=return-type]` - Fixed this by returning `NAT_BEHAVIOR_NONE_STR`
vikramdattu
force-pushed
the
bugfix/get_nat_behavior_return
branch
from
b3c8d1c to
16b1377
Compare
|
Hello @sirknightj updated the commit description as well as the PR details. Also, I have changed the target branch to develop. |
sirknightj
approved these changes
Apr 25, 2025
stefankiesz
approved these changes
Apr 28, 2025
unicornss
approved these changes
May 1, 2025
|
CI passing: #2119 |
sirknightj
added a commit
that referenced
this pull request
May 7, 2025
* Add MIPS32 cross compilation, refactor existing cross-compilation jobs (#2091) * MIPS32 cross compilation, threadpool, and use DRY * Add the ZLIB changes too * Address comment * Add opus sample frame generation GStreamer command to the readme (#2098) * Add data channel option to the readme (#2099) * Add data channel option to the readme * Address comments * Fixing the SPS/PPS/VPS for the H.265 samples to ensure that Safari playback does not pause. (#2111) * Upgrade to Ubuntu 22, refactor CI to use DRY, seperate the jobs (#2116) * Upgrade to Ubuntu 22, refactor CI to use DRY, seperate the jobs * Additional cleanup * Fix the uint16 promotion case (#2101) * Cleaning up stale resources, adjusted logging (#2117) * Global log level * Add progress bar and run the deletion script * Undo git_shallow for non-tagged versions * Install dependencies for AWS SDK CPP * Use ubuntu 22 container for the codecov * Downgrade to Ubuntu 20 * Add CD and change to bash * Install curl * Increase history for codecov * Seperate the steps for generating the report and uploading it * Configure LWS logs with KVS log level (#2118) * getNatBehaviorStr: Fix function return value compile error (#2114) - Following error was seen: `In function 'getNatBehaviorStr': NatBehaviorDiscovery.c:385:1: error: control reaches end of non-void function [-Werror=return-type]` - Fixed this by returning `NAT_BEHAVIOR_NONE_STR` * Allow branches named with pattern 'test-pr-*' to trigger the CI (#2120) * Increase the signaling message receive buffer size (#2126) * Increase the buffer sizes to accomodate for H.265 support in Chrome * Bump the project version to 1.12.1 * 2x was too much, make it less --------- Co-authored-by: Siva Somasundaram <34496097+unicornss@users.noreply.github.com> Co-authored-by: Vikram Dattu <dattuvikram@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix issue where compiler complains on function return type!
In function 'getNatBehaviorStr': NatBehaviorDiscovery.c:385:1: error: control reaches end of non-void function [-Werror=return-type]NAT_BEHAVIOR_NONE_STR