crypto/mbedtls: Add support for mbedtls 3.x #2112
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vikramdattu
force-pushed
the
support/mbedtls_3.x
branch
from
38fbb72 to
97740cd
Compare
|
@unicornss @sirknightj please start reviewing this change. |
vikramdattu
force-pushed
the
support/mbedtls_3.x
branch
from
97740cd to
49c15c3
Compare
sirknightj
reviewed
May 14, 2025
vikramdattu
force-pushed
the
support/mbedtls_3.x
branch
2 times, most recently
from
a762bed to
a36b94f
Compare
vikramdattu
commented
May 15, 2025
vikramdattu
force-pushed
the
support/mbedtls_3.x
branch
4 times, most recently
from
455832f to
a3dfa88
Compare
vikramdattu
force-pushed
the
support/mbedtls_3.x
branch
3 times, most recently
from
5fb85ba to
e2ef4c2
Compare
sirknightj
reviewed
May 20, 2025
- mbedtls 2.8.x is getting out of support: https://github.com/Mbed-TLS/mbedtls/releases/tag/mbedtls-2.28.10 - Clone mbedtls 3.6.x instead of 2.8.x via CMake dependencies - Add related code to mbedtls usage keeping the 2.8.x support intact under mbedtls version macros
vikramdattu
force-pushed
the
support/mbedtls_3.x
branch
from
e2ef4c2 to
f5d3bc5
Compare
sirknightj
approved these changes
May 21, 2025
stefankiesz
approved these changes
May 22, 2025
- This release handles mbedtls_3.x version support and has some fixes - Cleanup: removed libwebsocket patches as they are not needed anymore
- New API tlsSessionStartWithHostname can receive optional hostname and set the same - It is recommened to set the hostname and is on by default for mbedtls v3.6.3 and above - Since we receive ICE server credentials via secure API and anyway are use DTLS as WebRTC standard, we could skip this, but let's follow the recommendation as precaution
- Newer(3.6.x) mbedtls versions does not test builds on GCC versions as old as 4.4 - We keep this test for older mbedtls version (2.28.x)
vikramdattu
force-pushed
the
support/mbedtls_3.x
branch
from
f5d3bc5 to
875d520
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
What was changed?
mbedtls version is updated to 3.x
Why was it changed?
2.x has reached its end of life and is not maintained anymore
How was it changed?
Support was added to the sources to support mbedtls 3.x under version check
The CMake dependency updated
What testing was done for the changes?
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.