Skip to content

feat: custom domain name support for private endpoints #3719

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 9 commits into from
Mar 19, 2025

Conversation

Vandita2020
Copy link
Contributor

@Vandita2020 Vandita2020 commented Feb 13, 2025

Issue #, if available

Description of changes

The AWS API Gateway now supports the ability to use custom domain names for private endpoints. Two new resources have been introduced to enable this feature - AWS::ApiGateway::DomainNameV2 and AWS::ApiGateway::BasePathMappingV2.

Description of how you validated changes

Checklist

Examples?

Please reach out in the comments if you want to add an example. Examples will be
added to sam init through aws/aws-sam-cli-app-templates.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@mbfreder mbfreder requested a review from valerena March 7, 2025 22:55
@mbfreder
Copy link
Contributor

Test failures are unrelated.

Copy link
Contributor

@valerena valerena left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I added a few comments. I'll finish the review later

@Vandita2020 Vandita2020 merged commit 6468430 into aws:develop Mar 19, 2025
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants