-
Notifications
You must be signed in to change notification settings - Fork 13
Add integration for setting up SQS event source for a Lambda function. #47
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
49cc63a
to
5790641
Compare
"Mock Lambda Test Tool": { | ||
"commandName": "Executable", | ||
"commandLineArgs": "--port 5050", | ||
"workingDirectory": ".\\bin\\$(Configuration)\\net8.0", | ||
"executablePath": "%USERPROFILE%\\.dotnet\\tools\\dotnet-lambda-test-tool-8.0.exe" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can we remove this line?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Deleted. I also added a gitignore entry for playground launchsettings.json.
"Aspire_ProcessorFunction": { | ||
"commandName": "Executable", | ||
"executablePath": "dotnet", | ||
"commandLineArgs": "exec --depsfile ./SQSProcessorFunction.deps.json --runtimeconfig ./SQSProcessorFunction.runtimeconfig.json %USERPROFILE%\\.dotnet\\tools\\.store\\amazon.lambda.testtool\\0.9.999\\amazon.lambda.testtool\\0.9.999\\content\\Amazon.Lambda.RuntimeSupport\\net8.0\\Amazon.Lambda.RuntimeSupport.dll SQSProcessorFunction::SQSProcessorFunction.Function::FunctionHandler", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i think this is here by accident right? you only want the one below - the 0.10.0 version
"workingDirectory": ".\\bin\\$(Configuration)\\net8.0", | ||
"executablePath": "dotnet" | ||
}, | ||
"Mock Lambda Test Tool": { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
same here
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i think this auto generated one from the aws toolkit will end up confusing customers - we should probably see about getting rid of this eventually sooner than later
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Deleted
everything else seems fine to me. approving assuming the other comments are addressed |
Issue #, if available:
#41
Description of changes:
This is the Aspire integration for the PR aws/aws-lambda-dotnet#2008 that adds the SQS event source.
Here is an example configuring the .NET Aspire app host to have an SQS event source for a Lambda function. The queue url can come from either a plain string or a CloudFormation/CDK resource.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.