Fix auto open details on selection issue in context menu actions #1292
+414
−161
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| const entityId = data[Number(rowIndex)].id; | ||
| setSelectedNodesIds(new Set([entityId])); | ||
| setSelectedEdgesIds(new Set([])); | ||
| console.log("Changing selection from NodesTabular"); |
arseny-bitquill
approved these changes
Oct 29, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes an issue where the auto open details on selection would conflict with the user's desire to show a specific sidebar panel (in this case, the expand panel).
The solution involved adding a new hook to manage the selection state and send all selection changes to it. I then added an option to skip the side effects (auto open details). This allows me to change the selection without running the auto open details side effect.
I also did a minor cleanup to remove some unnecessary abstractions around mapping the selected nodes/edges and out of focus nodes/edges to cytoscape compatible forms. This logic was moved in to
GraphViewerwhere it is needed, rather than in a shared module.Validation
Related Issues
Check List
license.
pnpm checksto ensure code compiles and meets standards.pnpm testto check if all tests are passing.Changelog.md.