Skip to content

Commit 3c238b5

Browse files
authored
chore: stop forcing golang/mock to upgrade for make test (#2448)
<!-- Provide summary of changes --> Right now when we are doing `make test` we always automatically upgrade `golang/mock` to the latest. This will break our CI if `golang/mock` introduces any breaking change to our tests. This PR fixes this issue. <!-- Issue number, if available. E.g. "Fixes #31", "Addresses #42, 77" --> By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.
1 parent bfcea07 commit 3c238b5

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

Makefile

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -128,7 +128,6 @@ e2e: build-e2e
128128

129129
.PHONY: tools
130130
tools:
131-
GOBIN=${GOBIN} go get github.com/golang/mock/mockgen
132131
GOBIN=${GOBIN} go get github.com/gobuffalo/packr/v2/packr2
133132
@echo "Installing custom resource dependencies" &&\
134133
cd ${SOURCE_CUSTOM_RESOURCES} && npm ci
@@ -140,6 +139,7 @@ site-local:
140139

141140
.PHONY: gen-mocks
142141
gen-mocks: tools
142+
GOBIN=${GOBIN} go get github.com/golang/mock/mockgen
143143
# TODO: make this more extensible?
144144
${GOBIN}/mockgen -package=mocks -destination=./internal/pkg/cli/mocks/mock_rg.go -source=./internal/pkg/cli/env_delete.go resourceGetter
145145
${GOBIN}/mockgen -source=./internal/pkg/term/progress/spinner.go -package=mocks -destination=./internal/pkg/term/progress/mocks/mock_spinner.go

0 commit comments

Comments
 (0)