Skip to content

Commit bfcea07

Browse files
authored
chore(spinner): increase render interval if CI=true (#2446)
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.
1 parent 05f0edc commit bfcea07

File tree

2 files changed

+12
-2
lines changed

2 files changed

+12
-2
lines changed

internal/pkg/term/progress/spinner.go

Lines changed: 6 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -6,6 +6,7 @@ package progress
66
import (
77
"fmt"
88
"io"
9+
"os"
910
"time"
1011

1112
"github.com/briandowns/spinner"
@@ -37,7 +38,11 @@ type Spinner struct {
3738

3839
// NewSpinner returns a spinner that outputs to w.
3940
func NewSpinner(w io.Writer) *Spinner {
40-
s := spinner.New(charset, 125*time.Millisecond, spinner.WithHiddenCursor(true))
41+
interval := 125 * time.Millisecond
42+
if os.Getenv("CI") == "true" {
43+
interval = 30 * time.Second
44+
}
45+
s := spinner.New(charset, interval, spinner.WithHiddenCursor(true))
4146
s.Writer = w
4247
return &Spinner{
4348
spin: s,

internal/pkg/term/progress/spinner_test.go

Lines changed: 6 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4,6 +4,7 @@
44
package progress
55

66
import (
7+
"os"
78
"strings"
89
"testing"
910
"time"
@@ -18,12 +19,16 @@ func TestNew(t *testing.T) {
1819
t.Run("it should initialize the spin spinner", func(t *testing.T) {
1920
buf := new(strings.Builder)
2021
got := NewSpinner(buf)
22+
wantedInterval := 125 * time.Millisecond
23+
if os.Getenv("CI") == "true" {
24+
wantedInterval = 30 * time.Second
25+
}
2126

2227
v, ok := got.spin.(*spin.Spinner)
2328
require.True(t, ok)
2429

2530
require.Equal(t, buf, v.Writer)
26-
require.Equal(t, 125*time.Millisecond, v.Delay)
31+
require.Equal(t, wantedInterval, v.Delay)
2732
})
2833
}
2934

0 commit comments

Comments
 (0)