Support auth scheme preference config #3268
Open
+281
−163
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Detected 2 possible performance regressions:
|
| ordered_auth = preferred_auth.each_with_object([]) do |pref, list| | ||
| next unless ENDPOINT_AUTH_PREFERENCE_MAP.key?(pref) | ||
|
|
||
| ENDPOINT_AUTH_PREFERENCE_MAP[pref].each { |name| list << { 'name' => name } } |
There was a problem hiding this comment.
Why is the list adding hashes of name to auth scheme names rather than just being a list of names? Is auth_schemes a list of name, auth_scheme_name key pairs?
There was a problem hiding this comment.
The endpoint auth schemes model has a list of maps in the same way, so I transformed the preference list to be the same, then added them together. This overall made the logic and change simpler.
jterapin
approved these changes
Jul 7, 2025
gems/aws-sdk-core/lib/aws-sdk-core/plugins/credentials_configuration.rb
Outdated
Show resolved
Hide resolved
gems/aws-sdk-core/lib/aws-sdk-core/plugins/credentials_configuration.rb
Outdated
Show resolved
Hide resolved
…ration.rb Co-authored-by: Juli Tera <57973151+jterapin@users.noreply.github.com>
…ration.rb Co-authored-by: Juli Tera <57973151+jterapin@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Support auth scheme preference config using
ENV['AWS_AUTH_SCHEME_PREFERENCE']orauth_scheme_preferenceshared config. Configuration values are an array in code and a comma separated string in env/shared config and do not use name spaces. Invalid values are ignored. If an auth scheme is resolved and preferred, the credentials/token is expected. This differs from original design because v3 does not resolve auth per operation but rather on client initialize.