-
Notifications
You must be signed in to change notification settings - Fork 1.2k
Support bearer tokens through environment for Bedrock #3266
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: version-3
Are you sure you want to change the base?
Conversation
You have made a change to core without a corresponding change to the CHANGELOG.md. This change will not result in a new version and will not published unless an entry is added to CHANGELOG.md. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good overall - minor comments.
gems/aws-sdk-bedrock/lib/aws-sdk-bedrock/plugins/bearer_authorization.rb
Outdated
Show resolved
Hide resolved
Detected 1 possible performance regressions:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice - LGTM
Supports bearer tokens through ENV only for Bedrock. Scoped to two clients for now (others are planned). Precedence of the bearer token will also enforce this auth scheme preference (not yet implemented). A metric is added when used.
Alternate approach is to put logic in TokenProviderChain to read from ENV (perhaps a future generalized approach can do this).