-
Notifications
You must be signed in to change notification settings - Fork 1.2k
Default to standard retry #3236
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: version-3
Are you sure you want to change the base?
Conversation
Detected 7 possible performance regressions:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM ✨
Co-authored-by: Juli Tera <57973151+jterapin@users.noreply.github.com>
gems/aws-sdk-dynamodb/lib/aws-sdk-dynamodb/plugins/extended_retries.rb
Outdated
Show resolved
Hide resolved
docstring: <<-DOCS) do |cfg| | ||
Specifies which retry algorithm to use. Values are: | ||
docstring: <<~DOCS) do |cfg| | ||
Specifies which retry algorithm to use. Values are: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it would be worthwhile to link this resource: https://docs.aws.amazon.com/sdkref/latest/guide/feature-retry-behavior.html
I believe this documentation is very current since it was linked to the blogpost as a point of reference: https://aws.amazon.com/blogs/developer/updating-aws-sdk-defaults-aws-sts-service-endpoint-and-retry-strategy/
docstring: <<~DOCS) do |cfg| | ||
Used only in `standard` and `adaptive` retry modes. Specifies whether to apply | ||
a clock skew correction and retry requests with skewed client clocks. | ||
DOCS |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I was expecting see this configuration to be mentioned in the AWS SDK documentation on retries. If this is necessary, we should probably see if someone could update the documentation.
|
||
option( | ||
:max_attempts, | ||
default: 10, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Was there a reason why it was 10
attempts? I was curious
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not certain. Probably because of throttling and can be loss of data.
gems/aws-sdk-dynamodb/lib/aws-sdk-dynamodb/plugins/extended_retries.rb
Outdated
Show resolved
Hide resolved
Co-authored-by: Juli Tera <57973151+jterapin@users.noreply.github.com>
Sets the default retry strategy to standard.
This is a mild breaking change, rendering some config values useless (since standard doesn't have too many configurable options).
DynamoDB extended retries will include a new default of 10 retries but no configurable jitter/backoff policy unless configured back to legacy.
Other changes to the retry plugin are rubocop related.