Remove credential config of GetBucketRegion by default #3081
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Juneezee
reviewed
May 3, 2025
Comment on lines
74
to
+80
| clientOptionFns[0] = func(options *s3.Options) { | ||
| options.APIOptions = append(options.APIOptions, captureBucketRegion.RegisterMiddleware) | ||
| } | ||
| copy(clientOptionFns[1:], optFns) | ||
| clientOptionFns[1] = func(options *s3.Options) { | ||
| options.Credentials = nil | ||
| } | ||
| copy(clientOptionFns[2:], optFns) |
There was a problem hiding this comment.
Thanks for fixing the bug!
Out of curiosity, is there a reason why we don't just set options.Credentials = nil directly in clientOptionFns[0]?
Suggested change
| clientOptionFns[0] = func(options *s3.Options) { | |
| options.APIOptions = append(options.APIOptions, captureBucketRegion.RegisterMiddleware) | |
| } | |
| copy(clientOptionFns[1:], optFns) | |
| clientOptionFns[1] = func(options *s3.Options) { | |
| options.Credentials = nil | |
| } | |
| copy(clientOptionFns[2:], optFns) | |
| clientOptionFns[0] = func(options *s3.Options) { | |
| options.APIOptions = append(options.APIOptions, captureBucketRegion.RegisterMiddleware) | |
| options.Credentials = nil | |
| } | |
| copy(clientOptionFns[1:], optFns) |
There was a problem hiding this comment.
It's just a idioms when I want to add a new functional config
lucix-aws
approved these changes
May 5, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The s3 transfer manager helper func
GetBucketRegionis ported from go v1 but missed default anonymous credential config, this PR patches the config back so user could get a public bucket's region without credentials.Fixes #3077