Skip to content

[3.9.0] Address cluster update failure when old capacity reservation has been deleted #6880

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 12, 2025

Conversation

hgreebe
Copy link
Contributor

@hgreebe hgreebe commented Jun 12, 2025

Description of changes

Tests

  • Ran released.yaml integ tests

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

… config has been deleted

(cherry picked from commit 275a62e)
…instance type specified

(cherry picked from commit 97af77a)
@hgreebe hgreebe requested a review from a team as a code owner June 12, 2025 16:28
@hgreebe hgreebe added the skip-changelog-update Disables the check that enforces changelog updates in PRs label Jun 12, 2025
@hgreebe hgreebe requested a review from a team as a code owner June 12, 2025 16:28
@hgreebe hgreebe enabled auto-merge (rebase) June 12, 2025 16:28
@hgreebe hgreebe merged commit d0a9f2b into aws:integ-tests-3.9.0 Jun 12, 2025
23 of 29 checks passed
Copy link

codecov bot commented Jun 12, 2025

Codecov Report

Attention: Patch coverage is 66.66667% with 2 lines in your changes missing coverage. Please review.

Project coverage is 90.20%. Comparing base (011616c) to head (68af33b).
Report is 2 commits behind head on integ-tests-3.9.0.

Files with missing lines Patch % Lines
cli/src/pcluster/config/cluster_config.py 66.66% 2 Missing ⚠️
Additional details and impacted files
@@                  Coverage Diff                  @@
##           integ-tests-3.9.0    #6880      +/-   ##
=====================================================
- Coverage              90.21%   90.20%   -0.02%     
=====================================================
  Files                    181      181              
  Lines                  15838    15840       +2     
=====================================================
  Hits                   14288    14288              
- Misses                  1550     1552       +2     
Flag Coverage Δ
unittests 90.20% <66.66%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
skip-changelog-update Disables the check that enforces changelog updates in PRs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants