[3.13.0] Address cluster update failure when old capacity reservation has been deleted #6869
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… config has been deleted
…instance type specified
hanwen-cluster
added
the
skip-changelog-update
himani2411
reviewed
Jun 11, 2025
| capacity_reservations = AWSApi.instance().ec2.describe_capacity_reservations([capacity_reservation_id]) | ||
| if capacity_reservations: | ||
| instance_type = capacity_reservations[0].instance_type() | ||
| except AWSClientError: |
There was a problem hiding this comment.
Nitpick: Can we check if AWSClientError can also be cause by any other reason.
If this is caused because of any other reason and we set InstanceType None, will it affect the ComputeFleet during scaling where the launch template defines the Capacity reservation but doesnt define the instance-Type?
NOTE: The non-existance of this InstanceType can affect slurm configuration files to some extent where we wont be able to use Feature constrains using instanceType
There was a problem hiding this comment.
Before FDM's fix
pcluster create-cluster --cluster-configuration /Users/hanwenli/.parallelcluster/basicconfig --cluster-name cluster-name-dcv --region us-east-1
{
"message": "Invalid cluster configuration: An error occurred when calling the DescribeCapacityReservations operation: The capacity reservation ID 'cr-0c05c40da26fd1111' was not found"
}
After the fix:
pcluster create-cluster --cluster-configuration /Users/hanwenli/.parallelcluster/basicconfig --cluster-name cluster-name-dcv --region us-east-1
{
"message": "Invalid cluster configuration: Error validating parameter. Failed with exception: Parameter validation failed:\nInvalid type for parameter InstanceTypes[0], value: None, type: <class 'NoneType'>, valid types: <class 'str'>"
}
Anyway, the cluster creation will fail. This fix is really limited to fix update-cluster and update-compute-fleet
himani2411
approved these changes
Jun 11, 2025
hanwen-cluster
merged commit e90b85c
into
aws:integ-tests-3.13.0
25 of 27 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cherry picked from #6867
Please review the guidelines for contributing and Pull Request Instructions.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.