Update Messaging Processing Framework template project #2020
Conversation
GarrettBeatty
force-pushed
the
gcbeatty/messagingreadmeupdatestemplate
branch
from
6c9efe5 to
44e2917
Compare
|
One thing i wasnt sure on if we want to include the launchSettings.json or not? Right now we do not (its in the gitignore and we also do not include it in the zip). So i opted to not include it. But I was thinking if we include it then the user will not have to create one themselves and it would be a little easier for them. Although i guess the proper solution is updating the toolkit to work with the new test tool |
| @@ -11,10 +11,11 @@ | |||
| <PublishReadyToRun>true</PublishReadyToRun> | |||
| </PropertyGroup> | |||
| <ItemGroup> | |||
| <PackageReference Include="Amazon.Lambda.Annotations" Version="1.6.1" /> | |||
| <PackageReference Include="Amazon.Lambda.Annotations" Version="1.7.0" /> | |||
| <PackageReference Include="Amazon.Lambda.Core" Version="2.5.0" /> | |||
| <PackageReference Include="Amazon.Lambda.Serialization.SystemTextJson" Version="2.4.4" /> | |||
| <PackageReference Include="Amazon.Lambda.SQSEvents" Version="2.2.0" /> | |||
| <PackageReference Include="AWS.Messaging.Lambda" Version="0.9.0" /> | |||
There was a problem hiding this comment.
It would be good to update this version to the latest. Especially since this is the library we are demonstrating with the template.
There was a problem hiding this comment.
updated to have latest message lambda version
That sounds like an effort we would do when we want to update all of the templates. |
| "Name": "Amazon.Lambda.Templates", | ||
| "Type": "Patch", | ||
| "ChangelogMessages": [ | ||
| "Update message processing framework template." |
There was a problem hiding this comment.
nit: use the official name of the library to clearly state what was updated
|
|
||
| The functions can be tested with the [Mock Lambda Test Tool](https://github.com/aws/aws-lambda-dotnet/tree/master/Tools/LambdaTestTool) in Visual Studio or other IDEs. | ||
| ### Prerequisites | ||
| The functions can be tested with the [Mock Lambda Test Tool](https://github.com/aws/aws-lambda-dotnet/tree/master/Tools/LambdaTestTool-v2). |
There was a problem hiding this comment.
nit: drop the word "Mock". Also be consistent when you refer to the tool. I see 4 different names: Mock Lambda Test Tool, test tool, AWS Lambda Test Tool and Lambda Test Tool
Issue #, if available: https://sim.amazon.com/issues/DOTNET-8036
Description of changes:
Testing
it ran successfully with the
handlerandsenderprovidedBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.