Fix Amazon.Lambda.TestTool is missing icon and other package metadata #1974
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
normj
force-pushed
the
normj/fix-icon
branch
from
71802cc to
929bb53
Compare
philasmar
approved these changes
Feb 11, 2025
GarrettBeatty
approved these changes
Feb 11, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes:
Noticed that Amazon.Lambda.TestTool is missing an icon when looking at the package in NuGet. I have the package reference our common props. This also meant the package is now strong named so the
InternalsVisibleTofor the unit tests needed to be updated.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.