Fix compiler warnings for unit and integration test project #1950
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
marked this pull request as ready for review
ghost
commented
Jan 28, 2025
| @@ -172,13 +172,13 @@ private async Task RunApiGatewayTest<T>(HttpContextTestCase testCase, string api | |||
|
|
|||
| CompareApiGatewayRequests(expectedApiGatewayRequest, actualApiGatewayRequest); | |||
|
|
|||
| testCase.Assertions(actualApiGatewayRequest, emulatorMode); | |||
| testCase.Assertions(actualApiGatewayRequest!, emulatorMode); | |||
There was a problem hiding this comment.
i dont think this can ever be null
ghost
added
the
Release Not Needed
normj
approved these changes
Jan 29, 2025
ghost
force-pushed
the
gcbeatty/compiler2
branch
from
4d0183b to
cb8fb50
Compare
philasmar
approved these changes
Feb 3, 2025
GarrettBeatty
added a commit
that referenced
this pull request
Feb 6, 2025
fix compiler warnings for it project (#1950)
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available: DOTNET-7935
Description of changes: Fix compiler warnings in integration test and regular project. Most of them are due to null checks.
Testing. I ran all unit tests and integration tests locally on my machine and they pass
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.