Skip to content

feat: use offcanvas for function switching #1921

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 13, 2025

Conversation

philasmar
Copy link
Contributor

@philasmar philasmar commented Dec 30, 2024

Issue #, if available:
DOTNET-7864

Description of changes:

  • Added offcanvas control to display available functions
  • Removed the lambda function drop down in favor of offcanvas for a more modern UI
  • The home page now shows the selected function name as the title
  • Clicking on the function name or the switch lambda button will open the offcanvas
  • The button to switch functions now starts glowing when a new function is added. When you click on it, the glow goes away.

No or default function registered:
image

Registering more functions shows a new button to switch the selected Lambda
image

Clicking on Lambda name or switch lambda button:
image

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@philasmar philasmar requested review from normj and a user December 30, 2024 15:44
@philasmar philasmar force-pushed the asmarp/update-switch-lambda-ui branch from 1836321 to 899945a Compare December 30, 2024 19:07
@normj
Copy link
Member

normj commented Jan 2, 2025

I'm concerned about discoverability for switching functions. When running both a the test tool and a function hitting the test tool it took me a while to notice where the switch functionality was at. And I knew to look for it. A user with little context might have a harder time.

If changes the user experience from a one gesture of changing a drop down box to clicking about on the far right of the screen and then go all the way over to the left side of the screen.

My comments are subjective and I agree it looks nice but I not sure it makes the user experience better.

@philasmar philasmar force-pushed the asmarp/update-switch-lambda-ui branch from 899945a to 0c134ca Compare January 29, 2025 16:10
@philasmar philasmar changed the base branch from asmarp/lambda-function-dropdown to feature/lambdatesttool-v2 January 29, 2025 16:10
@philasmar philasmar added the Release Not Needed Add this label if a PR does not need to be released. label Jan 29, 2025
@philasmar philasmar force-pushed the asmarp/update-switch-lambda-ui branch from 0c134ca to 27b3a58 Compare January 29, 2025 17:20
Copy link

@ghost ghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

dropdown vs offcanvas doesnt matter too much to me tbh. Im fine if we want to merge this change since we can always get feedback and change it later if needed

@philasmar philasmar force-pushed the asmarp/update-switch-lambda-ui branch from 27b3a58 to a3f63a4 Compare January 30, 2025 19:39
@philasmar philasmar force-pushed the asmarp/update-switch-lambda-ui branch from a3f63a4 to 80513ca Compare February 12, 2025 18:20
@philasmar philasmar changed the base branch from feature/lambdatesttool-v2 to dev February 12, 2025 18:20
@philasmar philasmar merged commit fa24fc4 into dev Feb 13, 2025
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Release Not Needed Add this label if a PR does not need to be released.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants