Skip to content

Replace reference of LogLevel enum from Core to RuntimeSupport version #1820

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 25, 2024

Conversation

normj
Copy link
Member

@normj normj commented Sep 25, 2024

Description of changes:
While building the OCI images that include the new structured logging support the smoke tests failed due to the fact that the smoke test function had an old reference of Amazon.Lambda.Core that didn't have the LogLevel enum defined. The RuntimeSupport package had an unintended reference to the LogLevel enum that caused an undefined enum exception when an unhandled exception. This PR updates the LogLevel reference to the version defined in RuntimeSupport.

This only affects when deploying functions as a class library because the executable programming model will have a version of Amazon.Lambda.Core that matches with Amazon.Lambda.RuntimeSupport expects. So we don't need to patch the NuGet package and just need to get master updated which the OCI image builders use.

Testing

After change all OCI smoke tests pass. The test function is still referencing the old version of Amazon.Lambda.Core to exercise this corner case.

@normj normj merged commit cde803d into master Sep 25, 2024
1 check failed
@normj normj deleted the normj/fix-loglevel-enum-ref branch September 25, 2024 06:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants