Skip to content

Fixed AwsResolver.CreateProperties() to use logical OR condition when checking for Amazon.Lambda.CloudWatchEvents.CloudWatchEvent type. #1780

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 30, 2024
Merged

Fixed AwsResolver.CreateProperties() to use logical OR condition when checking for Amazon.Lambda.CloudWatchEvents.CloudWatchEvent type. #1780

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion Libraries/src/Amazon.Lambda.Serialization.Json/AwsResolver.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -130,8 +130,9 @@ protected override IList<JsonProperty> CreateProperties(Type type, MemberSeriali
}
}
}
// If user is directly using CloudWatchEvent class or using a derived type created in custom namespace.
else if (type.FullName.StartsWith("Amazon.Lambda.CloudWatchEvents.")
&& (type.GetTypeInfo().BaseType?.FullName?.StartsWith("Amazon.Lambda.CloudWatchEvents.CloudWatchEvent`",
|| (type.GetTypeInfo().BaseType?.FullName?.StartsWith("Amazon.Lambda.CloudWatchEvents.CloudWatchEvent`",
StringComparison.Ordinal) ?? false))
{
foreach (JsonProperty property in properties)
Expand Down
Loading