fix: support more connection errors in reboot test #695
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mselim00
force-pushed
the
reboot-test
branch
2 times, most recently
from
fe50df3 to
4e11b6d
Compare
ndbaker1
approved these changes
Sep 30, 2025
mselim00
force-pushed
the
reboot-test
branch
from
4e11b6d to
2cd3b0b
Compare
mselim00
force-pushed
the
reboot-test
branch
from
2cd3b0b to
6469cb9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Description of changes:
After running this test a few more times, I saw some cases where a different error would be returned by the kubelet health check and lead to an unnecessary failure. I was mainly seeing this with
connection reset by peer, which presumably happened if kubelet was killed in the middle of the/healthzcheck, but I also added in the errorclient connection lostwhich should cover the same.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.