fix: make reboot test more deterministic #693
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Description of changes:
Some improvements on top of #692
Switches to directly using kubelet
/healthzrequests instead of pod exec being killed with a 143 for gauging that the instance has started shutting down. This brings more determinism in two ways:ContainerCreatingwhile the node was rebooting, if the creation was early enough in the shutdown cycle.Also switches from assigning pods to nodes to allowing the scheduler to do so. This makes sure we're not bypassing any health checks the scheduler provides.
New sample happy path output:
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.